Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55363 )
Change subject: soc/intel/common: Add HECI Reset flow in the CSE driver ......................................................................
soc/intel/common: Add HECI Reset flow in the CSE driver
This change is required as part of HECI Interface initialization in order to put the host and CSE into a known good state for communication. Please refer ME BIOS specification for more details. The change adds HECI interface reset flow in the CSE driver. It enables coreboot to send HECI commands before DRAM Init.
BUG=b:175516533 TEST=Run 50 cold reset cycles on Brya
Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com Change-Id: Ie078beaa33c6a35ae8f5f460d4354766aa710fba Reviewed-on: https://review.coreboot.org/c/coreboot/+/55363 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index e41e337..68a41e8 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -111,6 +111,9 @@
/* Enable Bus Master and MMIO Space */ pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY); + + /* Trigger HECI Reset and make Host ready for communication with CSE */ + heci_reset(); }
static uint32_t read_bar(pci_devfn_t dev, uint32_t offset)