Change in coreboot[master]: mb/google/octopus: Remove LPDDR4 RAMID index 5,6 CH[1] only SKU
Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34069 )
Change subject: mb/google/octopus: Remove LPDDR4 RAMID index 5,6 CH[1] only SKU ......................................................................
mb/google/octopus: Remove LPDDR4 RAMID index 5,6 CH[1] only SKU
From Intel EDS: Table 3-5. LPDDR4 Configurations
CH00 CH01 CH10 CH11 "x32 BGA" "x32 BGA" "x32 BGA" "x32 BGA" "x32 BGA" "x32 BGA" "Unpopulated" "Unpopulated"
CH[1](CH10/CH11) can't use alone without CH[0]
BUG=b:135498646 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage Change-Id: I03af74301aad3e688c97992b37c59b20a4fff58a Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/octopus/variants/baseboard/memory.c 1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/34069/1
diff --git a/src/mainboard/google/octopus/variants/baseboard/memory.c b/src/mainboard/google/octopus/variants/baseboard/memory.c index 604295b..233ef84 100644 --- a/src/mainboard/google/octopus/variants/baseboard/memory.c +++ b/src/mainboard/google/octopus/variants/baseboard/memory.c @@ -178,17 +178,6 @@ .ch0_rank_density = LP4_8Gb_DENSITY, .ch0_dual_rank = 1, }, - /* Single Channel Configs 4GiB System Capacity Ch1 populated. */ - [5] = { - .speed = LP4_SPEED_2400, - .ch1_rank_density = LP4_16Gb_DENSITY, - }, - /* Single Channel Configs 4GiB System Capacity Ch1 populated. */ - [6] = { - .speed = LP4_SPEED_2400, - .ch1_rank_density = LP4_8Gb_DENSITY, - .ch1_dual_rank = 1, - }, /* Dual Channel Config 6GiB System Capacity */ [7] = { .speed = LP4_SPEED_2400,
Hello Aaron Durbin, Kane Chen, build bot (Jenkins), Keith Tzeng,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34069
to look at the new patch set (#2).
Change subject: mb/google/octopus: Remove LPDDR4 RAMID index 5,6 CH[1] only SKU ......................................................................
mb/google/octopus: Remove LPDDR4 RAMID index 5,6 CH[1] only SKU
From Intel EDS: Table 3-5. LPDDR4 Configurations
CH00 CH01 CH10 CH11 "x32 BGA" "x32 BGA" "x32 BGA" "x32 BGA" "x32 BGA" "x32 BGA" "Unpopulated" "Unpopulated"
CH[1](CH10/CH11) can't use alone without CH[0]
BUG=b:135498646,b:136694293 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage Change-Id: I03af74301aad3e688c97992b37c59b20a4fff58a Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/octopus/variants/baseboard/memory.c 1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/34069/2
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34069 )
Change subject: mb/google/octopus: Remove LPDDR4 RAMID index 5,6 CH[1] only SKU ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34069 )
Change subject: mb/google/octopus: Remove LPDDR4 RAMID index 5,6 CH[1] only SKU ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34069 )
Change subject: mb/google/octopus: Remove LPDDR4 RAMID index 5,6 CH[1] only SKU ......................................................................
mb/google/octopus: Remove LPDDR4 RAMID index 5,6 CH[1] only SKU
From Intel EDS: Table 3-5. LPDDR4 Configurations
CH00 CH01 CH10 CH11 "x32 BGA" "x32 BGA" "x32 BGA" "x32 BGA" "x32 BGA" "x32 BGA" "Unpopulated" "Unpopulated"
CH[1](CH10/CH11) can't use alone without CH[0]
BUG=b:135498646,b:136694293 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage Change-Id: I03af74301aad3e688c97992b37c59b20a4fff58a Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34069 Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/baseboard/memory.c 1 file changed, 0 insertions(+), 11 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/baseboard/memory.c b/src/mainboard/google/octopus/variants/baseboard/memory.c index 604295b..233ef84 100644 --- a/src/mainboard/google/octopus/variants/baseboard/memory.c +++ b/src/mainboard/google/octopus/variants/baseboard/memory.c @@ -178,17 +178,6 @@ .ch0_rank_density = LP4_8Gb_DENSITY, .ch0_dual_rank = 1, }, - /* Single Channel Configs 4GiB System Capacity Ch1 populated. */ - [5] = { - .speed = LP4_SPEED_2400, - .ch1_rank_density = LP4_16Gb_DENSITY, - }, - /* Single Channel Configs 4GiB System Capacity Ch1 populated. */ - [6] = { - .speed = LP4_SPEED_2400, - .ch1_rank_density = LP4_8Gb_DENSITY, - .ch1_dual_rank = 1, - }, /* Dual Channel Config 6GiB System Capacity */ [7] = { .speed = LP4_SPEED_2400,
-
Justin TerAvest (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Kevin Chiu (Code Review)
-
Patrick Georgi (Code Review)