Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31673
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
MAINTAINERS: Update Braswell SoC maintainers
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Id815db60e3718bf141abcc7923ea073bbab4a516 --- M MAINTAINERS 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/31673/1
diff --git a/MAINTAINERS b/MAINTAINERS index fbaad69..103c325 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -307,7 +307,10 @@
INTEL BRASWELL SOC M: Hannah Williams hannah.williams@intel.com -S: Supported +M: Piotr Król piotr.krol@3mdeb.com +M: Michał Żygowski michal.zygowski@3mdeb.com +M: Frans Hendriks fhendriks@eltan.com +S: Maintained F: /src/soc/intel/braswell F: /src/vendorcode/intel/fsp/fsp1_1/braswell
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31673/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31673/1//COMMIT_MSG@8 PS1, Line 8: You also change the status, which is not clear in the commit message.
Please elaborate.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31673/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/#/c/31673/1/MAINTAINERS@307 PS1, Line 307: remove hannah as well?
Hello Patrick Rudolph, Matt DeVillier, Paul Menzel, Stefan Reinauer, hannah.williams@dell.com, Philipp Deppenwiese, build bot (Jenkins), Hannah Williams, Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31673
to look at the new patch set (#2).
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
MAINTAINERS: Update Braswell SoC maintainers
Remove former Intel employee from maintainers of Braswell SoC.
Add 3mdeb and Eltan representatives as Braswell SoC maintainers.
Also mark Braswell SoC as maintained.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Id815db60e3718bf141abcc7923ea073bbab4a516 --- M MAINTAINERS 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/31673/2
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31673/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31673/1//COMMIT_MSG@8 PS1, Line 8:
You also change the status, which is not clear in the commit message. […]
Done
https://review.coreboot.org/#/c/31673/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/#/c/31673/1/MAINTAINERS@307 PS1, Line 307:
remove hannah as well?
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2: Code-Review+2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2: Code-Review+1
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2:
Hannah,
I assume hannahwilliam2 is your actual email address. Should we keep you as MAINTAINER?
hannah.williams@dell.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2:
Patch Set 2:
Hannah,
I assume hannahwilliam2 is your actual email address. Should we keep you as MAINTAINER?
Please remove my name as maintainer. I added Balaji so he can find out whose name from Intel can be added instead.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG@13 PS2, Line 13: Also mark Braswell SoC as maintained. Sorry, that’s visible from the diff. But why is the status demoted from *Supported* to *Maintained*. Thinking more about it, as it’s not clear from the commit message summary, please factor that out into a separate patch.
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG@9 PS2, Line 9: Remove former Intel employee from maintainers of Braswell SoC. : : Add 3mdeb and Eltan representatives as Braswell SoC maintainers. : : Also mark Braswell SoC as maintained. The items should be enumerated (or formatted as a list).
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
As-is this patch looks good. It will be great if Balaji can find a maintainer (maybe Subrata?) so that the SoC can remain "Supported" instead of just "Maintained".
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG@13 PS2, Line 13: Also mark Braswell SoC as maintained.
Sorry, that’s visible from the diff. But why is the status demoted from *Supported* to *Maintained*. […]
The 3mdeb and Eltan people are not paid by Intel to continually look after this SoC (AFAIK), although they support mainboards that use the SoC To promote this back up to "Supported" somebody from Intel should step in to take ownership of the code. (See the detailed descriptions near the top of MAINTAINERS)
I don't think it needs to be factored out into a separate patch - The former maintainer from Intel has moved on to other things and thus it makes sense to change the status while updating the list of people involved with this SoC.
Piotr Król has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG@13 PS2, Line 13: Also mark Braswell SoC as maintained.
The 3mdeb and Eltan people are not paid by Intel to continually look after this SoC (AFAIK), althoug […]
This is correct. 3mdeb is not paid by Intel to maintain Braswell, but we would definitely be glad to :)
We will soon push code for 2 Protectli network appliance platforms based on Braswell SoC.
We needed Frans patches and after testing, we can confirm those can be merged. As Michał wrote on the mailing list we have hardware and we are commited to support Braswell development. I think it is much better to have a really "Supported" SoC then one which just claims to be "Maintained".
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2:
(1 comment)
As-is this patch looks good. It will be great if Balaji can find a maintainer (maybe Subrata?) so that the SoC can remain "Supported" instead of just "Maintained".
Yes David, i can take a look into this and see at Intel we have some team to support those SOCs while we are working on latest.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG@13 PS2, Line 13: Also mark Braswell SoC as maintained. I was aware of that, when writing my comment, but I had to look up the definition, which should not be necessary, when looking at the change-set.
Supported: Someone is continuously paid to look after this and a reaction to review requests can be expected within a few days, a month at most. Maintained: Someone actually looks after it and a reaction to review requests can usually be expected within a few weeks.
Anyway, here is my suggestion.
Also, mark Braswell SoC as maintained, as now nobody is continuously paid to look after this anymore.
PS: Also, to avoid confusion, I’d say, that the maintainer necessary does not have to come from Intel, and that additionally, if some company has a product with that device, indirectly one could argue that people are paid to also look after the device (and SoC).
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31673/2//COMMIT_MSG@13 PS2, Line 13: Also mark Braswell SoC as maintained.
I was aware of that, when writing my comment, but I had to look up the definition, which should not […]
So should we keep it as supported then?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
Patch Set 2:
This can be changed again when there's a decision on who supports it, submitting now.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31673 )
Change subject: MAINTAINERS: Update Braswell SoC maintainers ......................................................................
MAINTAINERS: Update Braswell SoC maintainers
Remove former Intel employee from maintainers of Braswell SoC.
Add 3mdeb and Eltan representatives as Braswell SoC maintainers.
Also mark Braswell SoC as maintained.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Id815db60e3718bf141abcc7923ea073bbab4a516 Reviewed-on: https://review.coreboot.org/c/coreboot/+/31673 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: David Hendricks david.hendricks@gmail.com Reviewed-by: Piotr Król piotr.krol@3mdeb.com --- M MAINTAINERS 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Nico Huber: Looks good to me, approved Piotr Król: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, but someone else must approve
diff --git a/MAINTAINERS b/MAINTAINERS index fbaad69..04f784f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -306,8 +306,10 @@ F: /src/mainboard/intel/strago/
INTEL BRASWELL SOC -M: Hannah Williams hannah.williams@intel.com -S: Supported +M: Piotr Król piotr.krol@3mdeb.com +M: Michał Żygowski michal.zygowski@3mdeb.com +M: Frans Hendriks fhendriks@eltan.com +S: Maintained F: /src/soc/intel/braswell F: /src/vendorcode/intel/fsp/fsp1_1/braswell
-
David Hendricks (Code Review) -
Frans Hendriks (Code Review)
-
Michał Żygowski (Code Review)
-
Name of user not set (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Piotr Król (Code Review)
-
Subrata Banik (Code Review)