Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81262?usp=email )
Change subject: mb/google/brya: Create a tivviks variant ......................................................................
Patch Set 2:
(4 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81262/comment/c77a64e4_0ab16aa3 : PS1, Line 463: select SOC_INTEL_TWINLAKE
Acknowledged
Done.
https://review.coreboot.org/c/coreboot/+/81262/comment/c1a98ab7_ac01df37 : PS1, Line 464: select BOARD_ROMSIZE_KB_32768 : select DRIVERS_GENERIC_GPIO_KEYS : select DRIVERS_GENESYSLOGIC_GL9750 : select DRIVERS_I2C_SX9324 : select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER : select DRIVERS_INTEL_MIPI_CAMERA : select HAVE_WWAN_POWER_SEQUENCE : select INTEL_GMA_HAVE_VBT
why not something like this […]
I initially tried it (https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...) but it resulted in recursive dependency issue so reverted it back.
https://review.coreboot.org/c/coreboot/+/81262/comment/6179a016_4b7a3f8c : PS1, Line 581: BOARD_GOOGLE_TIVVIKS
Acknowledged
Done.
https://review.coreboot.org/c/coreboot/+/81262/comment/e4588ab9_89a00198 : PS1, Line 665: BOARD_GOOGLE_TIVVIKS
Acknowledged
Done.