Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/27015 )
Change subject: src: Move constant to the right side of comparison
......................................................................
Patch Set 2:
`if (const == variable)` is a pattern to make accidental `=` a compile error: `if (const = variable)` is a compile time error, `if (variable = const)` is not.
So while we might or might not want to have this idiom in our tree, it's bound to pop up again...
--
To view, visit
https://review.coreboot.org/27015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7
Gerrit-Change-Number: 27015
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 11 Jun 2018 08:48:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No