[S] Change in coreboot[main]: mb/google/nissa/var/glassway: Adjust touchscreen power sequencing

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81135?usp=email )

Change subject: mb/google/nissa/var/glassway: Adjust touchscreen power sequencing
......................................................................

mb/google/nissa/var/glassway: Adjust touchscreen power sequencing

Adjust touchscreen power sequencing for eKTH5015M.

The INX touch panel (eKTH5015M) contains a pull-up register which causes TCHSCR_REPORT_EN pull-up abnormally from Z1 power on.Because the t25 must be at least greater than 20ms, TCHSCR_REPORT_EN is initialized to GPO_L in the early stage (romstage) to meet the spec.

BUG=b:328170008
BRANCH=firmware-nissa-15217.B
TEST=Build and check I2C devices timing meet spec.
[INFO ]  input: Elan Touchscreen as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-10/i2c-ELAN0001:00/input/in4

Change-Id: I50f9c21ddee2bc9c1d313f63049cb587b4ae047a
Signed-off-by: Frank Chu 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81135
Reviewed-by: Matt DeVillier 
Reviewed-by: Eric Lai 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/brya/variants/glassway/gpio.c
M src/mainboard/google/brya/variants/glassway/overridetree.cb
2 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Eric Lai: Looks good to me, approved
  Frank Chu: Looks good to me, but someone else must approve
  Matt DeVillier: Looks good to me, approved
  build bot (Jenkins): Verified

diff --git a/src/mainboard/google/brya/variants/glassway/gpio.c b/src/mainboard/google/brya/variants/glassway/gpio.c
index d3510a1..79697d5 100644
--- a/src/mainboard/google/brya/variants/glassway/gpio.c
+++ b/src/mainboard/google/brya/variants/glassway/gpio.c
@@ -100,6 +100,8 @@
    PAD_CFG_GPO(GPP_C0, 1, DEEP),
    /* C1  : SMBDATA ==> USI_RST_L */
    PAD_CFG_GPO(GPP_C1, 0, DEEP),
+	/* C6  : SML1CLK ==> TCHSCR_REPORT_EN */
+	PAD_CFG_GPO(GPP_C6, 0, DEEP),
    /* H12 : UART0_RTS# ==> SD_PERST_L */
    PAD_CFG_GPO(GPP_H12, 1, DEEP),
 };
diff --git a/src/mainboard/google/brya/variants/glassway/overridetree.cb b/src/mainboard/google/brya/variants/glassway/overridetree.cb
index 15b7d7e..8c779d7 100644
--- a/src/mainboard/google/brya/variants/glassway/overridetree.cb
+++ b/src/mainboard/google/brya/variants/glassway/overridetree.cb
@@ -323,13 +323,13 @@
    			register "desc" = ""ELAN Touchscreen""
    			register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)"
    			register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)"
-				register "reset_delay_ms" = "25"
+				register "reset_delay_ms" = "20"
    			register "reset_off_delay_ms" = "4"
    			register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
-				register "stop_delay_ms" = "25"
-				register "stop_off_delay_ms" = "2"
+				register "stop_delay_ms" = "5"
+				register "stop_off_delay_ms" = "25"
    			register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
-				register "enable_delay_ms" = "7"
+				register "enable_delay_ms" = "25"
    			register "has_power_resource" = "1"
    			device i2c 10 on
    				probe TOUCHSCREEN_SOURCE TOUCHSCREEN_UNPROVISIONED