Change in coreboot[master]: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
The LGA1151 supports multiple chip generations like SKylake, Kaby Lake, Coffee Lake and so on. The x11sch for example is a Coffee Lake platform with a LGA1151 socket. TO cover those changes aswell, we need to rename the folder to x11-lga1151-skykbl.
Change-Id: Id213e79d7bcb5b6630dd0354cfce542e30ec9573 Signed-off-by: Christian Walter christian.walter@9elements.com --- R src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig R src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig.name R src/mainboard/supermicro/x11-lga1151-skykbl/Makefile.inc R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-skykbl/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/bootblock.c R src/mainboard/supermicro/x11-lga1151-skykbl/cmos.layout R src/mainboard/supermicro/x11-lga1151-skykbl/devicetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/dsdt.asl R src/mainboard/supermicro/x11-lga1151-skykbl/ramstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/romstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/vboot-ro-rwab.fmd 18 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35622/1
diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/Kconfig rename to src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig.name b/src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig.name similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/Kconfig.name rename to src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig.name diff --git a/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc b/src/mainboard/supermicro/x11-lga1151-skykbl/Makefile.inc similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/Makefile.inc rename to src/mainboard/supermicro/x11-lga1151-skykbl/Makefile.inc diff --git a/src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl b/src/mainboard/supermicro/x11-lga1151-skykbl/acpi/ec.asl similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl rename to src/mainboard/supermicro/x11-lga1151-skykbl/acpi/ec.asl diff --git a/src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl b/src/mainboard/supermicro/x11-lga1151-skykbl/acpi/mainboard.asl similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl rename to src/mainboard/supermicro/x11-lga1151-skykbl/acpi/mainboard.asl diff --git a/src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl b/src/mainboard/supermicro/x11-lga1151-skykbl/acpi/superio.asl similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl rename to src/mainboard/supermicro/x11-lga1151-skykbl/acpi/superio.asl diff --git a/src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c b/src/mainboard/supermicro/x11-lga1151-skykbl/acpi_tables.c similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c rename to src/mainboard/supermicro/x11-lga1151-skykbl/acpi_tables.c diff --git a/src/mainboard/supermicro/x11-lga1151-series/board_info.txt b/src/mainboard/supermicro/x11-lga1151-skykbl/board_info.txt similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/board_info.txt rename to src/mainboard/supermicro/x11-lga1151-skykbl/board_info.txt diff --git a/src/mainboard/supermicro/x11-lga1151-series/bootblock.c b/src/mainboard/supermicro/x11-lga1151-skykbl/bootblock.c similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/bootblock.c rename to src/mainboard/supermicro/x11-lga1151-skykbl/bootblock.c diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout b/src/mainboard/supermicro/x11-lga1151-skykbl/cmos.layout similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/cmos.layout rename to src/mainboard/supermicro/x11-lga1151-skykbl/cmos.layout diff --git a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb b/src/mainboard/supermicro/x11-lga1151-skykbl/devicetree.cb similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/devicetree.cb rename to src/mainboard/supermicro/x11-lga1151-skykbl/devicetree.cb diff --git a/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl b/src/mainboard/supermicro/x11-lga1151-skykbl/dsdt.asl similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/dsdt.asl rename to src/mainboard/supermicro/x11-lga1151-skykbl/dsdt.asl diff --git a/src/mainboard/supermicro/x11-lga1151-series/ramstage.c b/src/mainboard/supermicro/x11-lga1151-skykbl/ramstage.c similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/ramstage.c rename to src/mainboard/supermicro/x11-lga1151-skykbl/ramstage.c diff --git a/src/mainboard/supermicro/x11-lga1151-series/romstage.c b/src/mainboard/supermicro/x11-lga1151-skykbl/romstage.c similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/romstage.c rename to src/mainboard/supermicro/x11-lga1151-skykbl/romstage.c diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt b/src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/board_info.txt similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt rename to src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/board_info.txt diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h b/src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/include/variant/gpio.h similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h rename to src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/include/variant/gpio.h diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb b/src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/overridetree.cb similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb rename to src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/overridetree.cb diff --git a/src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd b/src/mainboard/supermicro/x11-lga1151-skykbl/vboot-ro-rwab.fmd similarity index 100% rename from src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd rename to src/mainboard/supermicro/x11-lga1151-skykbl/vboot-ro-rwab.fmd
Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35622
to look at the new patch set (#2).
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
The LGA1151 supports multiple chip generations like SKylake, Kaby Lake, Coffee Lake and so on. The x11sch for example is a Coffee Lake platform with a LGA1151 socket. TO cover those changes aswell, we need to rename the folder to x11-lga1151-skykbl.
Change-Id: Id213e79d7bcb5b6630dd0354cfce542e30ec9573 Signed-off-by: Christian Walter christian.walter@9elements.com --- M Documentation/mainboard/index.md R src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig R src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig.name R src/mainboard/supermicro/x11-lga1151-skykbl/Makefile.inc R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-skykbl/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/bootblock.c R src/mainboard/supermicro/x11-lga1151-skykbl/cmos.layout R src/mainboard/supermicro/x11-lga1151-skykbl/devicetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/dsdt.asl R src/mainboard/supermicro/x11-lga1151-skykbl/ramstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/romstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/vboot-ro-rwab.fmd 19 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35622/2
Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35622
to look at the new patch set (#3).
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
The LGA1151 supports multiple chip generations like SKylake, Kaby Lake, Coffee Lake and so on. The x11sch for example is a Coffee Lake platform with a LGA1151 socket. To cover those changes aswell, we need to rename the folder to x11-lga1151-skykbl.
Change-Id: Id213e79d7bcb5b6630dd0354cfce542e30ec9573 Signed-off-by: Christian Walter christian.walter@9elements.com --- M Documentation/mainboard/index.md R src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig R src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig.name R src/mainboard/supermicro/x11-lga1151-skykbl/Makefile.inc R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-skykbl/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/bootblock.c R src/mainboard/supermicro/x11-lga1151-skykbl/cmos.layout R src/mainboard/supermicro/x11-lga1151-skykbl/devicetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/dsdt.asl R src/mainboard/supermicro/x11-lga1151-skykbl/ramstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/romstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/vboot-ro-rwab.fmd 19 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35622/3
Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35622
to look at the new patch set (#4).
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
The LGA1151 supports multiple chip generations like SKylake, Kaby Lake, Coffee Lake and so on. The x11sch for example is a Coffee Lake platform with a LGA1151 socket. To cover those changes aswell, we need to rename the folder to x11-lga1151-skykbl.
Change-Id: Id213e79d7bcb5b6630dd0354cfce542e30ec9573 Signed-off-by: Christian Walter christian.walter@9elements.com --- M Documentation/mainboard/index.md D src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig A src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig.name R src/mainboard/supermicro/x11-lga1151-skykbl/Makefile.inc R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-skykbl/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/bootblock.c R src/mainboard/supermicro/x11-lga1151-skykbl/cmos.layout R src/mainboard/supermicro/x11-lga1151-skykbl/devicetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/dsdt.asl R src/mainboard/supermicro/x11-lga1151-skykbl/ramstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/romstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/vboot-ro-rwab.fmd 20 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35622/4
Hello Patrick Rudolph, Michael Niewöhner, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35622
to look at the new patch set (#5).
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
The LGA1151 supports multiple chip generations like SKylake, Kaby Lake, Coffee Lake and so on. The x11sch for example is a Coffee Lake platform with a LGA1151 socket. To cover those changes aswell, we need to rename the folder to x11-lga1151-skykbl.
Change-Id: Id213e79d7bcb5b6630dd0354cfce542e30ec9573 Signed-off-by: Christian Walter christian.walter@9elements.com --- M Documentation/mainboard/index.md D src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig A src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig.name R src/mainboard/supermicro/x11-lga1151-skykbl/Makefile.inc R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-skykbl/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/bootblock.c R src/mainboard/supermicro/x11-lga1151-skykbl/cmos.layout R src/mainboard/supermicro/x11-lga1151-skykbl/devicetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/dsdt.asl R src/mainboard/supermicro/x11-lga1151-skykbl/ramstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/romstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/vboot-ro-rwab.fmd 20 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35622/5
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 5:
Good catch!
Well, what about x11-lga1151v1-series? The inofficial name of LGA1151 for coffee lake is LGA1151v2, so we could have x11-lga1151v1-series and x11-lga1151v2-series
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35622/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35622/5//COMMIT_MSG@9 PS5, Line 9: SKylake Skylake
https://review.coreboot.org/c/coreboot/+/35622/5//COMMIT_MSG@11 PS5, Line 11: aswell as well
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 5:
Patch Set 5:
Good catch!
Well, what about x11-lga1151v1-series? The inofficial name of LGA1151 for coffee lake is LGA1151v2, so we could have x11-lga1151v1-series and x11-lga1151v2-series
I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Hello Patrick Rudolph, Michael Niewöhner, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35622
to look at the new patch set (#6).
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl
The LGA1151 supports multiple chip generations like Skylake, Kaby Lake, Coffee Lake and so on. The x11sch for example is a Coffee Lake platform with a LGA1151 socket. To cover those changes as well, we need to rename the folder to x11-lga1151-skykbl.
Change-Id: Id213e79d7bcb5b6630dd0354cfce542e30ec9573 Signed-off-by: Christian Walter christian.walter@9elements.com --- M Documentation/mainboard/index.md D src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig A src/mainboard/supermicro/x11-lga1151-skykbl/Kconfig.name R src/mainboard/supermicro/x11-lga1151-skykbl/Makefile.inc R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-skykbl/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-skykbl/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/bootblock.c R src/mainboard/supermicro/x11-lga1151-skykbl/cmos.layout R src/mainboard/supermicro/x11-lga1151-skykbl/devicetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/dsdt.asl R src/mainboard/supermicro/x11-lga1151-skykbl/ramstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/romstage.c R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-skykbl/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-skykbl/vboot-ro-rwab.fmd 20 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35622/6
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
(2 comments)
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35622/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35622/5//COMMIT_MSG@9 PS5, Line 9: SKylake
Skylake
Ack
https://review.coreboot.org/c/coreboot/+/35622/5//COMMIT_MSG@11 PS5, Line 11: aswell
as well
Ack
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
I still do not like -lga1151- in the mainboard name. Two hours after -series was merged, you realised that name did not work after all... As noted earlier, I don't have strong opinions about this but new naming schemes should be argumented a bit better.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Patch Set 6:
I still do not like -lga1151- in the mainboard name. Two hours after -series was merged, you realised that name did not work after all... As noted earlier, I don't have strong opinions about this but new naming schemes should be argumented a bit better.
I am totally agreeing with you ;). But nvm - there was a discussion at IRC and it has been decided to merge this into the tree. So let's try to tune the naming such that it fits better. And lets not start the discussion again about if it should be in the tree anyways. If you dont want it there, revert the patch and discuss it there. :)
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
I still do not like -lga1151- in the mainboard name. Two hours after -series was merged, you realised that name did not work after all... As noted earlier, I don't have strong opinions about this but new naming schemes should be argumented a bit better.
I am totally agreeing with you ;). But nvm - there was a discussion at IRC and it has been decided to merge this into the tree. So let's try to tune the naming such that it fits better. And lets not start the discussion again about if it should be in the tree anyways. If you dont want it there, revert the patch and discuss it there. :)
We started the discussion MULTIPLE times and in the end most people aggreed. Let's find a better naming but, please, let's be CONSTRUCTIVE :-)
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Patch Set 5:
Patch Set 5:
Good catch!
Well, what about x11-lga1151v1-series? The inofficial name of LGA1151 for coffee lake is LGA1151v2, so we could have x11-lga1151v1-series and x11-lga1151v2-series
I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Ouch, yes... x11-lga1151-sklkbl-series :'D just kidding....
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 5:
Patch Set 5:
Good catch!
Well, what about x11-lga1151v1-series? The inofficial name of LGA1151 for coffee lake is LGA1151v2, so we could have x11-lga1151v1-series and x11-lga1151v2-series
I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Ouch, yes... x11-lga1151-sklkbl-series :'D just kidding....
Ok... here some facts from supermicro:
X11 is available with multiple different sockets, soldered and socketed, multiple chipsets and multiple cpu generations, multi- and single socket.
Single socket is encoded as the first letter S as in X11S -> prefix could be x11s-
Chipsets available: C232/C236, C242/C246 CPU generations grouped by socket/pin compatibility: v5/v6 (skl/kbl), v7/v8 (cnl/cfl)
There Intel Processor W (Skylake SP) boards which all have the prefix X11SR or X11SP.
Most boards that are compatible with X11SSH and X11SSM have the prefix X11SS. Guess what? Yes, there are exceptions... of course: X11SAT, X11SAE.
I looked at many board names at the mainboard matrix (SM website) and it seems, that the second char after X11 reflects the CPU generation: X11SS could mean X11S-SkyKabylake, while X11SC (as in X11SCL and many other Coffelake boards) could be X11S-CannonCoffeelake. This is pure speculation but seems to fit in 99%.
option 1)We could use x11ss- as prefix (and ignore that maybe the two exceptions X11SAT and X11SAE get into this group some day); The full name would be x11ss-lga1151-series and x11sc-lga1151-series, then.
option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6: Code-Review-1
I like the current name. Everyone is calling the Coffee Lake socket LGA1151v2 (or r2) anyway.
I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Cannon Lake doesn't have a socket at all.
option 1)We could use x11ss- as prefix (and ignore that maybe the two exceptions X11SAT and X11SAE get into this group some day); The full name would be x11ss-lga1151-series and x11sc-lga1151-series, then.
Please don't. No "you have to know Supermicro's encoding", please.
option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.
Sounds all much more confusing than the current name, to me.
However, if there are indeed BGA versions, then the chipset would be the next best thing to identify the line. So I throw `x11-sunrisepoint` into the ring.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Patch Set 6: Code-Review-1
I like the current name. Everyone is calling the Coffee Lake socket LGA1151v2 (or r2) anyway.
I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Cannon Lake doesn't have a socket at all.
Huh?
option 1)We could use x11ss- as prefix (and ignore that maybe the two exceptions X11SAT and X11SAE get into this group some day); The full name would be x11ss-lga1151-series and x11sc-lga1151-series, then.
Please don't. No "you have to know Supermicro's encoding", please.
You don't need to know anything about Supermicro's encoding... when I have a board X11SS<whatever>, I would look in the tree if there is a folder X11SS<blah>... it's that simple ;-)
option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.
Sounds all much more confusing than the current name, to me.
However, if there are indeed BGA versions, then the chipset would be the next best thing to identify the line. So I throw `x11-sunrisepoint` into the ring.
That isn't sufficient, as there are many sp board that are absolutely NOT compatible with the two we have currently.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
I like the current name. Everyone is calling the Coffee Lake socket LGA1151v2 (or r2) anyway.
I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Cannon Lake doesn't have a socket at all.
Huh?
IIRC, only a single SKU exists and it's a ULT model.
option 1)We could use x11ss- as prefix (and ignore that maybe the two exceptions X11SAT and X11SAE get into this group some day); The full name would be x11ss-lga1151-series and x11sc-lga1151-series, then.
Please don't. No "you have to know Supermicro's encoding", please.
You don't need to know anything about Supermicro's encoding... when I have a board X11SS<whatever>, I would look in the tree if there is a folder X11SS<blah>... it's that simple ;-)
"that simple" didn't you just say that there *are* exceptions. Please don't make a mess of it.
option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.
Sounds all much more confusing than the current name, to me.
However, if there are indeed BGA versions, then the chipset would be the next best thing to identify the line. So I throw `x11-sunrisepoint` into the ring.
That isn't sufficient, as there are many sp board that are absolutely NOT compatible with the two we have currently.
1. With a variant setup, how can any board with the same chipset be incompatible? 2. So you are saying all LGA1151(v1) are compatible but not all with SPT?
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Patch Set 6:
I like the current name. Everyone is calling the Coffee Lake socket LGA1151v2 (or r2) anyway.
I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Cannon Lake doesn't have a socket at all.
Huh?
IIRC, only a single SKU exists and it's a ULT model.
option 1)We could use x11ss- as prefix (and ignore that maybe the two exceptions X11SAT and X11SAE get into this group some day); The full name would be x11ss-lga1151-series and x11sc-lga1151-series, then.
Please don't. No "you have to know Supermicro's encoding", please.
You don't need to know anything about Supermicro's encoding... when I have a board X11SS<whatever>, I would look in the tree if there is a folder X11SS<blah>... it's that simple ;-)
"that simple" didn't you just say that there *are* exceptions. Please don't make a mess of it.
option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.
Sounds all much more confusing than the current name, to me.
However, if there are indeed BGA versions, then the chipset would be the next best thing to identify the line. So I throw `x11-sunrisepoint` into the ring.
That isn't sufficient, as there are many sp board that are absolutely NOT compatible with the two we have currently.
- With a variant setup, how can any board with the same chipset be incompatible?
- So you are saying all LGA1151(v1) are compatible but not all with SPT?
It seems to me that obviously the naming convention wasnt really well thought through.
How about revert the whole stuff and just go back to the normal convention? I know that it doubles the code, but it seems to me much easier than finding a convention, when there is no real logic in the naming of the x11 board.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
I like the current name. Everyone is calling the Coffee Lake socket LGA1151v2 (or r2) anyway.
> I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Cannon Lake doesn't have a socket at all.
Huh?
IIRC, only a single SKU exists and it's a ULT model.
option 1)We could use x11ss- as prefix (and ignore that maybe the two exceptions X11SAT and X11SAE get into this group some day); The full name would be x11ss-lga1151-series and x11sc-lga1151-series, then.
Please don't. No "you have to know Supermicro's encoding", please.
You don't need to know anything about Supermicro's encoding... when I have a board X11SS<whatever>, I would look in the tree if there is a folder X11SS<blah>... it's that simple ;-)
"that simple" didn't you just say that there *are* exceptions. Please don't make a mess of it.
option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.
Sounds all much more confusing than the current name, to me.
However, if there are indeed BGA versions, then the chipset would be the next best thing to identify the line. So I throw `x11-sunrisepoint` into the ring.
That isn't sufficient, as there are many sp board that are absolutely NOT compatible with the two we have currently.
- With a variant setup, how can any board with the same chipset be incompatible?
- So you are saying all LGA1151(v1) are compatible but not all with SPT?
It seems to me that obviously the naming convention wasnt really well thought through.
How about revert the whole stuff and just go back to the normal convention? I know that it doubles the code, but it seems to me much easier than finding a convention, when there is no real logic in the naming of the x11 board.
Um, what? The current naming seems quite reasonable. Apart from one argument (lga1151 vs. lga1151v2), I only see lowest quality bike- shedding here.
Maybe we should back off a little and ask, what problem are your trying to fix? Are you about to add support for the X11SCH and need to pick a name? If not, there is nothing to do atm.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6: Code-Review-1
Patch Set 6:
I like the current name. Everyone is calling the Coffee Lake socket LGA1151v2 (or r2) anyway.
> > I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Cannon Lake doesn't have a socket at all.
Huh?
IIRC, only a single SKU exists and it's a ULT model.
option 1)We could use x11ss- as prefix (and ignore that maybe the two exceptions X11SAT and X11SAE get into this group some day); The full name would be x11ss-lga1151-series and x11sc-lga1151-series, then.
Please don't. No "you have to know Supermicro's encoding", please.
You don't need to know anything about Supermicro's encoding... when I have a board X11SS<whatever>, I would look in the tree if there is a folder X11SS<blah>... it's that simple ;-)
"that simple" didn't you just say that there *are* exceptions. Please don't make a mess of it.
option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.
Sounds all much more confusing than the current name, to me.
However, if there are indeed BGA versions, then the chipset would be the next best thing to identify the line. So I throw `x11-sunrisepoint` into the ring.
That isn't sufficient, as there are many sp board that are absolutely NOT compatible with the two we have currently.
- With a variant setup, how can any board with the same chipset be incompatible?
- So you are saying all LGA1151(v1) are compatible but not all with SPT?
It seems to me that obviously the naming convention wasnt really well thought through.
How about revert the whole stuff and just go back to the normal convention? I know that it doubles the code, but it seems to me much easier than finding a convention, when there is no real logic in the naming of the x11 board.
Um, what? The current naming seems quite reasonable. Apart from one argument (lga1151 vs. lga1151v2), I only see lowest quality bike- shedding here.
Maybe we should back off a little and ask, what problem are your trying to fix? Are you about to add support for the X11SCH and need to pick a name? If not, there is nothing to do atm.
Reverting the whole stuff because of a not 100% perfect naming scheme is really exaggerated!
After thinking on this again I have to strongly aggree with Nico, that there shouldn't be done anything atm as there is no real problem. We can start that discussion again, when there is a need for. Let's concentrate on more important things.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.
Sounds all much more confusing than the current name, to me.
However, if there are indeed BGA versions, then the chipset would be the next best thing to identify the line. So I throw `x11-sunrisepoint` into the ring.
That isn't sufficient, as there are many sp board that are absolutely NOT compatible with the two we have currently.
- With a variant setup, how can any board with the same chipset be incompatible?
- So you are saying all LGA1151(v1) are compatible but not all with SPT?
Uhm, well, it was late... what I said is wrong, so x11-sunrisepoint could be an option
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Patch Set 6: Code-Review-1
Patch Set 6:
I like the current name. Everyone is calling the Coffee Lake socket LGA1151v2 (or r2) anyway.
> > > I am not 100% sure, but I guess Cannon Lake also uses this socket. Might be better to split this up as well or?
Cannon Lake doesn't have a socket at all.
Huh?
IIRC, only a single SKU exists and it's a ULT model.
> option 1)We could use x11ss- as prefix (and ignore that maybe the two exceptions X11SAT and X11SAE get into this group some day); The full name would be x11ss-lga1151-series and x11sc-lga1151-series, then.
Please don't. No "you have to know Supermicro's encoding", please.
You don't need to know anything about Supermicro's encoding... when I have a board X11SS<whatever>, I would look in the tree if there is a folder X11SS<blah>... it's that simple ;-)
"that simple" didn't you just say that there *are* exceptions. Please don't make a mess of it.
> > option 2) keep x11s- as prefix. Then we have to separate v5/v6 (skl/kbl), v7/v8 (cnl/cfl) by another tag. Examples: x11s-v5v6- and x11s-v7v8- or x11s-sklkbl- and x11s-cnlcfl- > Then we have 29 Boards with Socket 1151v1, and some with some FCBGA-*.
Sounds all much more confusing than the current name, to me.
However, if there are indeed BGA versions, then the chipset would be the next best thing to identify the line. So I throw `x11-sunrisepoint` into the ring.
That isn't sufficient, as there are many sp board that are absolutely NOT compatible with the two we have currently.
- With a variant setup, how can any board with the same chipset be incompatible?
- So you are saying all LGA1151(v1) are compatible but not all with SPT?
It seems to me that obviously the naming convention wasnt really well thought through.
How about revert the whole stuff and just go back to the normal convention? I know that it doubles the code, but it seems to me much easier than finding a convention, when there is no real logic in the naming of the x11 board.
Um, what? The current naming seems quite reasonable. Apart from one argument (lga1151 vs. lga1151v2), I only see lowest quality bike- shedding here.
Maybe we should back off a little and ask, what problem are your trying to fix? Are you about to add support for the X11SCH and need to pick a name? If not, there is nothing to do atm.
Reverting the whole stuff because of a not 100% perfect naming scheme is really exaggerated!
After thinking on this again I have to strongly aggree with Nico, that there shouldn't be done anything atm as there is no real problem. We can start that discussion again, when there is a need for. Let's concentrate on more important things.
Okay. I have a real problem because i am porting a board which I can not put into the tree like this. So until this is unresolved, I can not push it into gerrit.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Okay. I have a real problem because i am porting a board which I can not put into the tree like this. So until this is unresolved, I can not push it into gerrit.
Then elaborate please. Will it be another variant? or rather start a new series?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Patch Set 6:
Okay. I have a real problem because i am porting a board which I can not put into the tree like this. So until this is unresolved, I can not push it into gerrit.
Then elaborate please. Will it be another variant? or rather start a new series?
See commit message. Looks like Christian wants to add a port for a coffeelake Supermicro board named X11SCH. Since coffeelake+friends use different chipset code, compared to the existing skylake+friends boards, adding it as a variant is not really a good idea. And then, since coffeelake+friends use the same LGA1151 socket as skylake+friends, the current name is ambiguous.
@Christian while everyone bikesheds about namings around here, I would suggest adding the X11SCH in a folder called "x11sch", and worry about naming issues later on.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
I read the entire discussion. I see all sorts of silly problems with all the past, current and future names for this folder. I don't like any of them.
But you know what? It doesn't matter. The folder's name is irrelevant when it comes to building and running coreboot on hardware, so any changes to it won't make coreboot better.
So, what about stopping the bikeshedding and working on improving the code? Let's get that Supermicro Coffee Lake board ported and merged in. Let's get skylake code cleaned up a bit (SKL FSP 1.1 has been superseded by KBL FSP 2.0). And I'll try to port the several dozen mainboards I buried myself under over the years...
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Okay. I have a real problem because i am porting a board which I can not put into the tree like this. So until this is unresolved, I can not push it into gerrit.
Then elaborate please. Will it be another variant? or rather start a new series?
See commit message. Looks like Christian wants to add a port for a coffeelake Supermicro board named X11SCH. Since coffeelake+friends use different chipset code, compared to the existing skylake+friends boards, adding it as a variant is not really a good idea. And then, since coffeelake+friends use the same LGA1151 socket as skylake+friends, the current name is ambiguous.
Simple solution: name the new one x11-lga1151v2-series, then it should become clear.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
But you know what? It doesn't matter. The folder's name is irrelevant when it comes to building and running coreboot on hardware, so any changes to it won't make coreboot better.
...
So, what about stopping the bikeshedding and working on improving the code?
full ACK!
Simple solution: name the new one x11-lga1151v2-series, then it should become clear.
full ACK again!
Christian Walter has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Abandoned
Totally agree!
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35622 )
Change subject: mainboard/supermicro/x11-lga1151-series: Rename to x11-lga1151-skykbl ......................................................................
Patch Set 6:
Yay! Found this: https://www.supermicro.com/products/Product_Naming_Convention/Naming_MBD_Int...
x11ss-series == x11-lga1151-series x11sc-series == x11-lga1151v2-series
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
Kyösti Mälkki (Code Review)
-
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)