Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29423 )
Change subject: soc/intel/braswell: Configure IO APIC
......................................................................
Patch Set 8:
Patch Set 7:
Are we sure FSP doesn't do this already? It seems unlikely
that all the in tree Braswell devices don't use the APIC.
Maybe we only have to reserve the resources?
I noticed that FSP is configuring some registers also.
Will perform some tests, to reduce tasks of coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I917c30892b46ac1d964e7bab339082d17a1e706d
Gerrit-Change-Number: 29423
Gerrit-PatchSet: 8
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Mar 2019 08:53:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment