Change in coreboot[master]: soc/amd/common/block: Fix guards for PSP transfer buffer - coreboot-gerrit

10 Feb 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Julius Werner.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50403 )
Change subject: soc/amd/common/block: Fix guards for PSP transfer buffer
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/cpu/noncar/memlayout_transfer_buffer.inc:
https://review.coreboot.org/c/coreboot/+/50403/comment/184df5a2_e0328d7e 
PS1, Line 9: #if CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) || CONFIG(VBOOT_STARTS_IN_BOOTBLOCK)
...
You are right, VBOOT_STARTS_IN_ROMSTAGE is the only other option. […]
It accomplishes the same thing.  I think this is fine.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50403
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I444bede3f2b716e1900e7621453351d7fddadaa3
Gerrit-Change-Number: 50403
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Wed, 10 Feb 2021 16:23:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-MessageType: comment