Change in ...coreboot[master]: Add support for Hygon Dhyana processor

[Name of user not set (Code Review)]

Name of user not set #1002411 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32876

Change subject: Add support for Hygon Dhyana processor
......................................................................

Add support for Hygon Dhyana processor

src/arch/x86/cpu.c: Add hygon vendor string verify.

Background:
    Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture
    between AMD and Haiguang Information Technology Co.,Ltd., aims at
    providing high performance x86 processor for China server market.
    Its first generation processor codename is Dhyana, which
    originates from AMD technology and shares most of the
    architecture with AMD's family 17h, but with different CPU Vendor
    ID("HygonGenuine")/Family series number(Family 18h).

More details can be found on:
http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f921040e859b.1538583282...

Change-Id: I8af8b0f0675f978ac07522029696e43651a3153f
Signed-off-by: Jinke Fan 
---
M src/arch/x86/cpu.c
M src/arch/x86/include/arch/cpu.h
2 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32876/1

diff --git a/src/arch/x86/cpu.c b/src/arch/x86/cpu.c
index e6c9435..cfab219 100644
--- a/src/arch/x86/cpu.c
+++ b/src/arch/x86/cpu.c
@@ -113,6 +113,7 @@
    { X86_VENDOR_TRANSMETA, "TransmetaCPU", },
    { X86_VENDOR_NSC,       "Geode by NSC", },
    { X86_VENDOR_SIS,       "SiS SiS SiS ", },
+	{ X86_VENDOR_HYGON,     "HygonGenuine", },
 };

static const char *const x86_vendor_name[] = {
@@ -126,6 +127,7 @@
    [X86_VENDOR_TRANSMETA] = "Transmeta",
    [X86_VENDOR_NSC]       = "NSC",
    [X86_VENDOR_SIS]       = "SiS",
+	[X86_VENDOR_HYGON]     = "Hygon",
 };

static const char *cpu_vendor_name(int vendor)
diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h
index 078ea17..ff1a33b 100644
--- a/src/arch/x86/include/arch/cpu.h
+++ b/src/arch/x86/include/arch/cpu.h
@@ -152,6 +152,7 @@
 #define X86_VENDOR_TRANSMETA  8
 #define X86_VENDOR_NSC        9
 #define X86_VENDOR_SIS       10
+#define X86_VENDOR_HYGON     11
 #define X86_VENDOR_ANY     0xfe
 #define X86_VENDOR_UNKNOWN 0xff

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: Add support for Hygon Dhyana processor
......................................................................

Patch Set 1: Code-Review+2

Great! Welcome to our OSS firmware community :)

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: Add support for Hygon Dhyana processor
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@9 
PS1, Line 9: verify
Just say Add vendor string is enough?

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: Add support for Hygon Dhyana processor
......................................................................

Patch Set 1: Code-Review+1

(3 comments)

Welcome to the coreboot community. I am looking forward to your contributions.

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@7 
PS1, Line 7: Add support for Hygon Dhyana processor
           : 
           : src/arch/x86/cpu.c: Add hygon vendor string verify.
Please collapse both lines to one commit message summary.
> arch/x86/cpu: Add define and strings for Hygon

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@11 
PS1, Line 11: Background:
            :     Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture
            :     between AMD and Haiguang Information Technology Co.,Ltd., aims at
            :     providing high performance x86 processor for China server market.
            :     Its first generation processor codename is Dhyana, which
            :     originates from AMD technology and shares most of the
            :     architecture with AMD's family 17h, but with different CPU Vendor
            :     ID("HygonGenuine")/Family series number(Family 18h).
Maybe remove *Background:*, and remove the indentation.

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@17 
PS1, Line 17: but with different CPU Vendor
            :     ID("HygonGenuine")/Family series number(Family 18h)
Please add a space before the opening (.

[Name of user not set (Code Review)]

Name of user not set #1002411 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: Add support for Hygon Dhyana processor
......................................................................

Patch Set 1:
> Patch Set 1:
>
> (1 comment)

Thanks for your comments,I will amend it according to Paul's suggestion.

[Name of user not set (Code Review)]

Hello Paul Menzel, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32876

to look at the new patch set (#2).

Change subject: Add support for Hygon Dhyana processor
......................................................................

Add support for Hygon Dhyana processor

arch/x86/cpu: Add define and strings for Hygon

Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture
between AMD and Haiguang Information Technology Co.,Ltd., aims
at providing high performance x86 processor for China server
market. Its first generation processor codename is Dhyana, which
originates from AMD technology and shares most of the architecture
with AMD's family 17h, but with different CPU Vendor ID ("HygonGenuine")
/Family series number (Family 18h).

More details can be found on:
http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f921040e859b.1538583282...

Change-Id: I8af8b0f0675f978ac07522029696e43651a3153f
Signed-off-by: Jinke Fan 
---
M src/arch/x86/cpu.c
M src/arch/x86/include/arch/cpu.h
2 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32876/2

[Name of user not set (Code Review)]

Name of user not set #1002411 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: Add support for Hygon Dhyana processor
......................................................................

Patch Set 2:

(3 comments)
> Patch Set 1: Code-Review+1
>
> (3 comments)
>
> Welcome to the coreboot community. I am looking forward to your contributions.

Thanks a lot for your kindness.

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@7 
PS1, Line 7: Add support for Hygon Dhyana processor
           : 
           : src/arch/x86/cpu.c: Add hygon vendor string verify.
> Please collapse both lines to one commit message summary. […]

done

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@11 
PS1, Line 11: Background:
            :     Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture
            :     between AMD and Haiguang Information Technology Co.,Ltd., aims at
            :     providing high performance x86 processor for China server market.
            :     Its first generation processor codename is Dhyana, which
            :     originates from AMD technology and shares most of the
            :     architecture with AMD's family 17h, but with different CPU Vendor
            :     ID("HygonGenuine")/Family series number(Family 18h).
> Maybe remove *Background:*, and remove the indentation.

done

https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@17 
PS1, Line 17: but with different CPU Vendor
            :     ID("HygonGenuine")/Family series number(Family 18h)
> Please add a space before the opening (.

done

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: Add support for Hygon Dhyana processor
......................................................................

Patch Set 2: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: Add support for Hygon Dhyana processor
......................................................................

Patch Set 2:

(1 comment)

Thank you for the update. Just one more nit, but it’s not that important.

https://review.coreboot.org/#/c/32876/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32876/2//COMMIT_MSG@8 
PS2, Line 8: 
Please remove the two lines above, and keep the one below as the summary. (See `git log --oneline`.)

Change in ...coreboot[master]: arch/x86/cpu: Add define and strings for Hygon

[Name of user not set (Code Review)]

Hello Paul Menzel, Lance Zhao, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32876

to look at the new patch set (#3).

Change subject: arch/x86/cpu: Add define and strings for Hygon
......................................................................

arch/x86/cpu: Add define and strings for Hygon

Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture
between AMD and Haiguang Information Technology Co.,Ltd., aims
at providing high performance x86 processor for China server
market. Its first generation processor codename is Dhyana, which
originates from AMD technology and shares most of the architecture
with AMD's family 17h, but with different CPU Vendor ID ("HygonGenuine")
/Family series number (Family 18h).

More details can be found on:
http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f921040e859b.1538583282...

Change-Id: I8af8b0f0675f978ac07522029696e43651a3153f
Signed-off-by: Jinke Fan 
---
M src/arch/x86/cpu.c
M src/arch/x86/include/arch/cpu.h
2 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32876/3

Change in ...coreboot[master]: arch/x86/cpu: Add define and strings for Hygon

[Name of user not set (Code Review)]

Name of user not set #1002411 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: arch/x86/cpu: Add define and strings for Hygon
......................................................................

Patch Set 3:
> Patch Set 2:
>
> (1 comment)
>
> Thank you for the update. Just one more nit, but it’s not that important.

I'm sorry for the late update and thanks for your comments.

Change in ...coreboot[master]: arch/x86/cpu: Add define and strings for Hygon

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: arch/x86/cpu: Add define and strings for Hygon
......................................................................

Patch Set 3: Code-Review+2

Welcome to coreboot! Looking forward to getting new platforms in coreboot :)

Change in ...coreboot[master]: arch/x86/cpu: Add define and strings for Hygon

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32876 )

Change subject: arch/x86/cpu: Add define and strings for Hygon
......................................................................

arch/x86/cpu: Add define and strings for Hygon

Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture
between AMD and Haiguang Information Technology Co.,Ltd., aims
at providing high performance x86 processor for China server
market. Its first generation processor codename is Dhyana, which
originates from AMD technology and shares most of the architecture
with AMD's family 17h, but with different CPU Vendor ID ("HygonGenuine")
/Family series number (Family 18h).

More details can be found on:
http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f921040e859b.1538583282...

Change-Id: I8af8b0f0675f978ac07522029696e43651a3153f
Signed-off-by: Jinke Fan 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32876
Reviewed-by: Angel Pons 
Reviewed-by: Lance Zhao 
Reviewed-by: Philipp Deppenwiese 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/arch/x86/cpu.c
M src/arch/x86/include/arch/cpu.h
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Philipp Deppenwiese: Looks good to me, approved
  Lance Zhao: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/arch/x86/cpu.c b/src/arch/x86/cpu.c
index e6c9435..cfab219 100644
--- a/src/arch/x86/cpu.c
+++ b/src/arch/x86/cpu.c
@@ -113,6 +113,7 @@
    { X86_VENDOR_TRANSMETA, "TransmetaCPU", },
    { X86_VENDOR_NSC,       "Geode by NSC", },
    { X86_VENDOR_SIS,       "SiS SiS SiS ", },
+	{ X86_VENDOR_HYGON,     "HygonGenuine", },
 };

static const char *const x86_vendor_name[] = {
@@ -126,6 +127,7 @@
    [X86_VENDOR_TRANSMETA] = "Transmeta",
    [X86_VENDOR_NSC]       = "NSC",
    [X86_VENDOR_SIS]       = "SiS",
+	[X86_VENDOR_HYGON]     = "Hygon",
 };

static const char *cpu_vendor_name(int vendor)
diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h
index 078ea17..ff1a33b 100644
--- a/src/arch/x86/include/arch/cpu.h
+++ b/src/arch/x86/include/arch/cpu.h
@@ -152,6 +152,7 @@
 #define X86_VENDOR_TRANSMETA  8
 #define X86_VENDOR_NSC        9
 #define X86_VENDOR_SIS       10
+#define X86_VENDOR_HYGON     11
 #define X86_VENDOR_ANY     0xfe
 #define X86_VENDOR_UNKNOWN 0xff