Hello Patrick Rudolph, Mimoja, Felix Singer, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37093
to review the following change.
Change subject: Revert "3rdparts/fsp: Update fsp submodule" ......................................................................
Revert "3rdparts/fsp: Update fsp submodule"
This reverts commit 0b82b3d6fdc413db5b65b08adc0d2a5ddc6687ad.
Reason for revert: Coffeelake FSP does not work anymore. FSP-M crashes/stuck.
Change-Id: I5fc8b349a3d79478ea996ce98c642ceddb44457b --- M 3rdparty/fsp M src/soc/intel/cannonlake/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37093/1
diff --git a/3rdparty/fsp b/3rdparty/fsp index 0bc2b07..5996417 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 0bc2b07eab29a8a75cd084963c285ee5434e6666 +Subproject commit 59964173e18950debcc6b8856c5c928935ce0b4f diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index c82660e..5c91ac1 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -310,7 +310,7 @@ config FSP_FD_PATH string depends on FSP_USE_REPO - default "3rdparty/fsp/CoffeeLakeFspBinPkg/Fsp.fd" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE + default "3rdparty/fsp/CoffeeLakeFspBinPkg/FSP.fd" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
config SOC_INTEL_CANNONLAKE_DEBUG_CONSENT int "Debug Consent for CNL"
Hello Patrick Rudolph, Mimoja, Felix Singer, build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37093
to look at the new patch set (#2).
Change subject: Revert "3rdparts/fsp: Update fsp submodule" ......................................................................
Revert "3rdparts/fsp: Update fsp submodule"
This reverts commit 0b82b3d6fdc413db5b65b08adc0d2a5ddc6687ad.
Reason for revert: Coffeelake FSP does not work anymore. FSP-M crashes/stuck.
Change-Id: I5fc8b349a3d79478ea996ce98c642ceddb44457b Signed-off-by: Christian Walter christian.walter@9elements.com --- M 3rdparty/fsp M src/soc/intel/cannonlake/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37093/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37093 )
Change subject: Revert "3rdparts/fsp: Update fsp submodule" ......................................................................
Patch Set 4: Code-Review+2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37093 )
Change subject: Revert "3rdparts/fsp: Update fsp submodule" ......................................................................
Patch Set 4: -Code-Review
Add files to revert?