Attention is currently required from: Tim Wawrzynczak, Stefan Reinauer, Kyösti Mälkki.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59003 )
Change subject: google/butterfly: Refactor get_recovery_mode_switch()
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5:
This board is from a time when vboot was still running in the payload (and this function only existed to pass the recovery mode state through lb_gpios, in ramstage). I assume recovery mode has been broken ever since we started pulling it into coreboot. We probably could as well remove Chrome OS support completely from this board now, I don't think anyone is ever going to bother fixing it up again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59003
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a0fdbb370d54898c72adb29a0e9b990a5fc0ce1
Gerrit-Change-Number: 59003
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 19:17:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment