build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25509 )
Change subject: [Do Not Merge] add i945G based mainboard ......................................................................
Patch Set 22:
(17 comments)
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... File src/mainboard/nec/945g-m4/romstage.c:
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... PS22, Line 140: [ 16.101663] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x2 line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... PS22, Line 141: [ 16.101785] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x2 line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... PS22, Line 142: [ 16.101859] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x36 line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... PS22, Line 143: [ 16.101974] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x36 line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... PS22, Line 144: [ 16.102086] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x36 line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... PS22, Line 145: [ 16.102156] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x38 line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... PS22, Line 146: [ 16.102250] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x38 line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... PS22, Line 147: [ 16.103089] snd_intel8x0 0000:00:1e.2: codec_write 0: semaphore is not ready for register 0x10 line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/romstage.... PS22, Line 151: [ 11.645291] snd_intel8x0m: probe of 0000:00:1e.3 failed with error -13 line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_h... File src/mainboard/nec/945g-m4/superio_hwm.c:
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_h... PS22, Line 83: //if (get_option(&cpufan_temperature, "cpufan_temperature") != CB_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_h... PS22, Line 90: //if (get_option(&sysfan_temperature, "sysfan_temperature") != CB_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_h... PS22, Line 135: hwm_write(0x06, fan_speeds[cpufan_speed].fan_in); // CPUFANIN target speed line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_h... PS22, Line 140: temperatures[cpufan_temperature].deg_fahrenheit); line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_h... PS22, Line 141: hwm_write(0x06, temperatures[cpufan_temperature].deg_celsius); // CPUFANIN target temperature line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_h... PS22, Line 149: hwm_write(0x05, fan_speeds[sysfan_speed].fan_in); // SYSFANIN target speed line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_h... PS22, Line 154: temperatures[sysfan_temperature].deg_fahrenheit); line over 80 characters
https://review.coreboot.org/#/c/25509/22/src/mainboard/nec/945g-m4/superio_h... PS22, Line 155: hwm_write(0x05, temperatures[sysfan_temperature].deg_celsius); // SYSFANIN target temperature line over 80 characters
-
build bot (Jenkins) (Code Review)