HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41288 )
Change subject: mb/google/drallion: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/google/drallion: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: I647688cbc654ab5840debcafd8f64253e161060e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/drallion/bootblock.c M src/mainboard/google/drallion/chromeos.c M src/mainboard/google/drallion/ramstage.c 3 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/41288/1
diff --git a/src/mainboard/google/drallion/bootblock.c b/src/mainboard/google/drallion/bootblock.c index 5bd5d02..4a0f65a 100644 --- a/src/mainboard/google/drallion/bootblock.c +++ b/src/mainboard/google/drallion/bootblock.c @@ -2,7 +2,7 @@
#include <bootblock_common.h> #include <ec/google/wilco/bootblock.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h>
static void early_config_gpio(void) diff --git a/src/mainboard/google/drallion/chromeos.c b/src/mainboard/google/drallion/chromeos.c index d92ebb1..82c0025 100644 --- a/src/mainboard/google/drallion/chromeos.c +++ b/src/mainboard/google/drallion/chromeos.c @@ -3,7 +3,6 @@ #include <acpi/acpi.h> #include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <security/tpm/tss.h> diff --git a/src/mainboard/google/drallion/ramstage.c b/src/mainboard/google/drallion/ramstage.c index 8725b83..00d3799 100644 --- a/src/mainboard/google/drallion/ramstage.c +++ b/src/mainboard/google/drallion/ramstage.c @@ -4,7 +4,7 @@ #include <boardid.h> #include <drivers/vpd/vpd.h> #include <smbios.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/ramstage.h> #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h>
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41288 )
Change subject: mb/google/drallion: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324