Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74100 )
Change subject: mb/google/myst: Add smihandler
......................................................................
Patch Set 19:
(3 comments)
File src/mainboard/google/myst/variants/baseboard/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74100/comment/0ac2d9f0_1834331b
PS19, Line 5: smm-y += gpio.c
no need here since you remove the table.
File src/mainboard/google/myst/variants/baseboard/smihandler.c:
https://review.coreboot.org/c/coreboot/+/74100/comment/fcaf5409_785b2d96
PS19, Line 4: #include <console/console.h>
not used here.
https://review.coreboot.org/c/coreboot/+/74100/comment/fc01ce12_31146a74
PS19, Line 8: #include <gpio.h>
not used here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74100
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92e5e6aef7ab0b84a96d976e29ebf96b56f6f1a1
Gerrit-Change-Number: 74100
Gerrit-PatchSet: 19
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 01:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment