Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33784 )
Change subject: mb/upsquared: Align partitions to 4KiB
......................................................................
Patch Set 4:
Patch Set 4: Code-Review+1
Note that you can also try to drop the @xxxx offset and sometimes the size. That way you have to compute less things. See for instance https://review.coreboot.org/c/coreboot/+/33276/1
Sounds good.
@Felix Let's update all FMDs in a separate commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33784
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1e99b74ded5f743a3ad4fc829ae9747276c483a
Gerrit-Change-Number: 33784
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Thu, 27 Jun 2019 11:52:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment