Attention is currently required from: Tarun Tuli, Victor Ding, Jason Nien, Martin Roth.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69192 )
Change subject: drivers/i2c/sx9324: Add support for Linux's SX9324 driver ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69192/comment/894b78e6_06da4634 PS3, Line 16: I think this could do with slightly more explanation. I.e. we want a single firmware build which can work with both kernel drivers by specifying both sets of properties, which is useful during the transition phase. And maybe mention the kernel versions in which the old driver was removed and the new driver added.
https://review.coreboot.org/c/coreboot/+/69192/comment/630bd5c7_ec2ef985 PS3, Line 18: TEST=Dump ACPI SSDT then verify they are identical w/ and w/o this patch This is not true, since the new properties will be added to the ACPI tables with zero values.
File src/drivers/i2c/sx9324/Kconfig:
https://review.coreboot.org/c/coreboot/+/69192/comment/13a3ef32_ce982c76 PS3, Line 13: Board may use the legacy sx932x linux driver. Could you add a few more details, similar to what I suggested for the commit message?
File src/drivers/i2c/sx9324/sx9324.c:
https://review.coreboot.org/c/coreboot/+/69192/comment/1996fe41_3bbeeff7 PS3, Line 72: cs_idle_sleep int_comp_resistor