Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39995 )
Change subject: mb/siemens/chili: Add Chili variant ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39995/15/src/mainboard/siemens/chil... File src/mainboard/siemens/chili/variants/chili/smbios.c:
PS15: Please remove the whole file and use `SECUNET_DMI` instead. Kconfig select + devicetree entry. See boxer26 for reference.
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... File src/mainboard/siemens/field_pg_m6/variants/chili/boxer26_eeprom.h:
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... PS1, Line 6: BOXER26
Is this Boxer26 though?
Whole file will be dropped.
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... File src/mainboard/siemens/field_pg_m6/variants/chili/smbios.c:
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... PS1, Line 33: MAX_STRING_LENGTH);
nit: should fit in 96 chars
Whole file will be dropped.
https://review.coreboot.org/c/coreboot/+/39995/1/src/mainboard/siemens/field... PS1, Line 72: const int le)
fits?
Whole file will be dropped.
-
Nico Huber (Code Review)