Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36120 )
Change subject: util/amdfwtool: Add holding locations for more APCBs ......................................................................
util/amdfwtool: Add holding locations for more APCBs
Increase the number of potential APCB images to 5 by adding to the amd_bios_table. New instance IDs are from 0 to 4. The backup APCB block (type 0x68) still supports only instance ID 0.
Change-Id: Ib70dc6417fecf94549a0c7df36ea42f63331be26 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/36120/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 2980622..02564cf 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -357,7 +357,11 @@ };
static amd_bios_entry amd_bios_table[] = { - { .type = AMD_BIOS_APCB, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 0, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 1, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 2, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 3, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 4, .level = BDT_BOTH }, { .type = AMD_BIOS_APCB_BK, .level = BDT_BOTH }, { .type = AMD_BIOS_APOB, .level = BDT_BOTH }, { .type = AMD_BIOS_BIN,
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36120 )
Change subject: util/amdfwtool: Add holding locations for more APCBs ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36120 )
Change subject: util/amdfwtool: Add holding locations for more APCBs ......................................................................
util/amdfwtool: Add holding locations for more APCBs
Increase the number of potential APCB images to 5 by adding to the amd_bios_table. New instance IDs are from 0 to 4. The backup APCB block (type 0x68) still supports only instance ID 0.
Change-Id: Ib70dc6417fecf94549a0c7df36ea42f63331be26 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36120 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 2980622..02564cf 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -357,7 +357,11 @@ };
static amd_bios_entry amd_bios_table[] = { - { .type = AMD_BIOS_APCB, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 0, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 1, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 2, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 3, .level = BDT_BOTH }, + { .type = AMD_BIOS_APCB, .inst = 4, .level = BDT_BOTH }, { .type = AMD_BIOS_APCB_BK, .level = BDT_BOTH }, { .type = AMD_BIOS_APOB, .level = BDT_BOTH }, { .type = AMD_BIOS_BIN,
-
Marshall Dawson (Code Review) -
Martin Roth (Code Review)