Change in ...coreboot[master]: src/soc/intel/cannonlake: Add _DSM methods for LPIT table - coreboot-gerrit

5 Feb 2019


      EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31101 )
Change subject: src/soc/intel/cannonlake: Add _DSM methods for LPIT table
......................................................................
Patch Set 15:
...
Patch Set 15:
...
Patch Set 15:
(1 comment)
I have a quick compare the dsdt.dsl generated and that's identical for patch 12 and patch 15, I may assume the didn't work will be caused by other regression on S0ix. ASL 2.0 had been introduced for several years and widely adopted in coreboot as well.
Agree, I tested on my local build. Result is passed and work well.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31101
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia908969decf7cf12f505becb4f4a4a9caa7ed6db
Gerrit-Change-Number: 31101
Gerrit-PatchSet: 15
Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com
Gerrit-Assignee: Shaunak Saha shaunak.saha@intel.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.com
Gerrit-Reviewer: Shaunak Saha shaunak.saha@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Feb 2019 15:54:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment