Change in coreboot[master]: tests: Move cmocka binary into $(obj)

List overview All Threads
Download

newer

older

Change in coreboot[master]: tests:...

Change in coreboot[master]:...

Patrick Georgi (Code Review)

27 May 2020 27 May '20

6:09 a.m.

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41770 )

Change subject: tests: Move cmocka binary into $(obj) ......................................................................

tests: Move cmocka binary into $(obj)

Put it in $(objutil) so that it's shared between board builds with abuild even if that doesn't matter right now.

Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M tests/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/41770/1

diff --git a/tests/Makefile.inc b/tests/Makefile.inc index a6689a2..f84fa30 100644 --- a/tests/Makefile.inc +++ b/tests/Makefile.inc @@ -3,7 +3,7 @@ testsrc = $(top)/tests testobj = $(obj)/tests cmockasrc = 3rdparty/cmocka -cmockaobj = $(cmockasrc)/build +cmockaobj = $(objutil)/cmocka

CMOCKA_LIB := $(cmockaobj)/src/libcmocka.so

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Angel Pons (Code Review)

27 May 27 May

6:35 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41770 )

Change subject: tests: Move cmocka binary into $(obj) ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/41770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95 Gerrit-Change-Number: 41770 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Comment-Date: Wed, 27 May 2020 09:35:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jan Dabros (Code Review)

8:29 a.m.

Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41770 )

Change subject: tests: Move cmocka binary into $(obj) ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41770/1/tests/Makefile.inc File tests/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/41770/1/tests/Makefile.inc@6 PS1, Line 6: cmockaobj = $(objutil)/cmocka One side effect of this change is that "make clean" will remove cmocka library. Probably this is desired behavior - we don't have target like "clean-all" right? "make clean" should clean everything, right?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95 Gerrit-Change-Number: 41770 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 11:29:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8:36 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41770 )

Change subject: tests: Move cmocka binary into $(obj) ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41770/1/tests/Makefile.inc File tests/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/41770/1/tests/Makefile.inc@6 PS1, Line 6: cmockaobj = $(objutil)/cmocka

...

One side effect of this change is that "make clean" will remove cmocka library. […]

We have distclean, but even that probably doesn't touch 3rdparty repositories. All in all, we try to keep sources and object files separate, and if people want a clean tree, then stuff gets rebuilt - simple as that :-)

-- To view, visit https://review.coreboot.org/c/coreboot/+/41770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95 Gerrit-Change-Number: 41770 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 11:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jan Dabros jsd@semihalf.com Gerrit-MessageType: comment

Jan Dabros (Code Review)

9:14 a.m.

Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41770 )

Change subject: tests: Move cmocka binary into $(obj) ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/41770/1/tests/Makefile.inc File tests/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/41770/1/tests/Makefile.inc@6 PS1, Line 6: cmockaobj = $(objutil)/cmocka

...

We have distclean, but even that probably doesn't touch 3rdparty repositories. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95 Gerrit-Change-Number: 41770 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 12:14:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Comment-In-Reply-To: Jan Dabros jsd@semihalf.com Gerrit-MessageType: comment

Martin Roth (Code Review)

7:44 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41770 )

Change subject: tests: Move cmocka binary into $(obj) ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95 Gerrit-Change-Number: 41770 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 22:44:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

8:48 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41770 )

Change subject: tests: Move cmocka binary into $(obj) ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95 Gerrit-Change-Number: 41770 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 May 2020 23:48:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

28 May 28 May

6:47 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41770 )

Change subject: tests: Move cmocka binary into $(obj) ......................................................................

tests: Move cmocka binary into $(obj)

Put it in $(objutil) so that it's shared between board builds with abuild even if that doesn't matter right now.

Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41770 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jan Dabros jsd@semihalf.com Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M tests/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Angel Pons: Looks good to me, approved Jan Dabros: Looks good to me, but someone else must approve

CMOCKA_LIB := $(cmockaobj)/src/libcmocka.so

-- To view, visit https://review.coreboot.org/c/coreboot/+/41770 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95 Gerrit-Change-Number: 41770 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Jan Dabros jsd@semihalf.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1790

days inactive

1791

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Jan Dabros (Code Review)
Martin Roth (Code Review)
Patrick Georgi (Code Review)