[L] Change in coreboot[main]: mb/intel/ptlrvp: Introduce PTL RVP External and Internal EC Configura... - coreboot-gerrit

10 Apr 2025


      Attention is currently required from: Bora Guvendik, Jamie Ryu, Zhixing Ma.
Jérémy Compostella has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/86991?usp=email )
Change subject: mb/intel/ptlrvp: Introduce PTL RVP External and Internal EC Configurations
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/intel/ptlrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/86991/comment/f47a7b49_1a9264aa?usp... :
PS5, Line 29:         /* Lid always open */
...
Jeremy I thought I fixed this already between patchset 6 and 7. Am I missing something? […]
This is indeed resolved, I mis-used gerrit WebUI. Discard it.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86991?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3e40f2a19d7ed4f7a16e6e516a284a9a778b9fd
Gerrit-Change-Number: 86991
Gerrit-PatchSet: 11
Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Zhixing Ma zhixing.ma@intel.com
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Zhixing Ma zhixing.ma@intel.com
Gerrit-Attention: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Comment-Date: Thu, 10 Apr 2025 22:15:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bora Guvendik bora.guvendik@intel.com
Comment-In-Reply-To: Jérémy Compostella jeremy.compostella@intel.com