Attention is currently required from: Jarried Lin, Yidi Lin.
Knox Chiou has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email )
Change subject: mb/google/rauru: Implement SKU ID
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/rauru/boardid.c:
https://review.coreboot.org/c/coreboot/+/85666/comment/f8ee5481_02ff6c7d?usp... :
PS7, Line 66: get_adc_index(SKU_ID_LOW_CHANNEL))
@knoxchiou@google. […]
I'd like to suggest the 0x7FFFXFFF and take "X" as storage type usage,
so we could reserve other bits for another unprovisioned domain needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85666?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49ba6f428f55d3aae1b84a4d5ce06bec765caece
Gerrit-Change-Number: 85666
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 20 Dec 2024 09:50:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com