Change in coreboot[master]: soc/intel/appololake: Allow to configure SATA ALPM via devicetree

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61401 )

Change subject: soc/intel/appololake: Allow to configure SATA ALPM via devicetree
......................................................................

soc/intel/appololake: Allow to configure SATA ALPM via devicetree

Add a devicetree option to disable SATA Aggressive Link Power
Management. ALPM is a method of saving power. The corresponding FSP-S
UPD parameter is enabled by default. It may be that this feature is
unwanted, for example for a real-time system. Therefore, allow to
disable ALPM using the devicetree.

Change-Id: Ica8920a87ebebe83f5d8cb4d6c8c0a6105e183e4
Signed-off-by: Mario Scheithauer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61401
Tested-by: build bot (Jenkins) 
Reviewed-by: Werner Zeh 
Reviewed-by: Paul Menzel 
---
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/chip.h
2 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Werner Zeh: Looks good to me, approved

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 98844a5..82ec2da 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -693,6 +693,10 @@

silconfig->PavpEnable = CONFIG(PAVP);

+	/* SATA config */
+	if (is_devfn_enabled(PCH_DEVFN_SATA))
+		silconfig->SataSalpSupport = !(cfg->DisableSataSalpSupport);
+
    mainboard_silicon_init_params(silconfig);
 }

diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h
index 482b333..f531381 100644
--- a/src/soc/intel/apollolake/chip.h
+++ b/src/soc/intel/apollolake/chip.h
@@ -190,6 +190,9 @@
     * 0:Enable (default), 1:Disable.
     */
    uint8_t disable_xhci_lfps_pm;
+
+	/* SATA Aggressive Link Power Management */
+	uint8_t DisableSataSalpSupport;
 };

typedef struct soc_intel_apollolake_config config_t;