Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Kevin Keijzer.
Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73519 )
Change subject: mb/asrock/b75pro3-m: Advertise RTL NIC as onboard ethernet device
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/asrock/b75pro3-m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73519/comment/78ec9aea_54671cd4
PS1, Line 77: subsystemid 0x1849 0x1e1a
Note: The subsystemid is now applied to the NIC, but not the root port.
I copied this idea from mb/gigabyte/ga-g41m-es2l, and it seems to work.
If the id is not applied to the rootport, is there anything that we can do to change that to make this better/more correct?
Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0550ee9faddd65011ad914aef413a6d1b316c5ad
Gerrit-Change-Number: 73519
Gerrit-PatchSet: 1
Gerrit-Owner: Fabian Groffen
grobian@gentoo.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Comment-Date: Wed, 08 Mar 2023 14:33:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment