Change in coreboot[master]: nb/amd/pi/00730F01/state_machine.c: unhardcode IOAPIC2 address

[Michał Żygowski (Code Review)]

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39701 )

Change subject: nb/amd/pi/00730F01/state_machine.c: unhardcode IOAPIC2 address
......................................................................

nb/amd/pi/00730F01/state_machine.c: unhardcode IOAPIC2 address

Signed-off-by: Michał Żygowski 
Change-Id: I95964ac6b5939f66c40bd56939bdf532a72d75ce
---
M src/northbridge/amd/pi/00730F01/state_machine.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/39701/1

diff --git a/src/northbridge/amd/pi/00730F01/state_machine.c b/src/northbridge/amd/pi/00730F01/state_machine.c
index 4a049e5..d78c575 100644
--- a/src/northbridge/amd/pi/00730F01/state_machine.c
+++ b/src/northbridge/amd/pi/00730F01/state_machine.c
@@ -19,6 +19,7 @@
 #include <device/device.h>
 #include <northbridge/amd/agesa/state_machine.h>
 #include <northbridge/amd/agesa/agesa_helper.h>
+#include <northbridge/amd/pi/nb_common.h>

void platform_BeforeInitReset(struct sysinfo *cb, AMD_RESET_PARAMS *Reset)
 {
@@ -63,7 +64,7 @@

/* 0 iGpuVgaAdapter, 1 iGpuVgaNonAdapter; */
    Mid->GnbMidConfiguration.iGpuVgaMode = 0;
-	Mid->GnbMidConfiguration.GnbIoapicAddress = 0xFEC20000;
+	Mid->GnbMidConfiguration.GnbIoapicAddress = IO_APIC2_ADDR;
 }

void platform_BeforeInitLate(struct sysinfo *cb, AMD_LATE_PARAMS *Late)

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39701 )

Change subject: nb/amd/pi/00730F01/state_machine.c: unhardcode IOAPIC2 address
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39701 )

Change subject: nb/amd/pi/00730F01/state_machine.c: unhardcode IOAPIC2 address
......................................................................

Patch Set 1: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39701 )

Change subject: nb/amd/pi/00730F01/state_machine.c: unhardcode IOAPIC2 address
......................................................................

nb/amd/pi/00730F01/state_machine.c: unhardcode IOAPIC2 address

Signed-off-by: Michał Żygowski 
Change-Id: I95964ac6b5939f66c40bd56939bdf532a72d75ce
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39701
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Paul Menzel 
---
M src/northbridge/amd/pi/00730F01/state_machine.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/amd/pi/00730F01/state_machine.c b/src/northbridge/amd/pi/00730F01/state_machine.c
index 4a049e5..d78c575 100644
--- a/src/northbridge/amd/pi/00730F01/state_machine.c
+++ b/src/northbridge/amd/pi/00730F01/state_machine.c
@@ -19,6 +19,7 @@
 #include <device/device.h>
 #include <northbridge/amd/agesa/state_machine.h>
 #include <northbridge/amd/agesa/agesa_helper.h>
+#include <northbridge/amd/pi/nb_common.h>

void platform_BeforeInitReset(struct sysinfo *cb, AMD_RESET_PARAMS *Reset)
 {
@@ -63,7 +64,7 @@

/* 0 iGpuVgaAdapter, 1 iGpuVgaNonAdapter; */
    Mid->GnbMidConfiguration.iGpuVgaMode = 0;
-	Mid->GnbMidConfiguration.GnbIoapicAddress = 0xFEC20000;
+	Mid->GnbMidConfiguration.GnbIoapicAddress = IO_APIC2_ADDR;
 }

void platform_BeforeInitLate(struct sysinfo *cb, AMD_LATE_PARAMS *Late)