Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31112
Change subject: soc/intel/common/rtc: Enable RTC if common code RTC ......................................................................
soc/intel/common/rtc: Enable RTC if common code RTC
Intel RTC common code driver need to turn on RTC itself.
BUG=b:123372643 TEST=build and boot up on sarien platform, check .config to see CONFIG_RTC is set.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I0c8c5cf9e6f7f338b1f2f784c04254649d257536 --- M src/soc/intel/common/block/rtc/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/31112/1
diff --git a/src/soc/intel/common/block/rtc/Kconfig b/src/soc/intel/common/block/rtc/Kconfig index d194f15..eda2063 100644 --- a/src/soc/intel/common/block/rtc/Kconfig +++ b/src/soc/intel/common/block/rtc/Kconfig @@ -1,4 +1,5 @@ config SOC_INTEL_COMMON_BLOCK_RTC bool + select RTC help Intel Processor common RTC support
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31112 )
Change subject: soc/intel/common/rtc: Enable RTC if common code RTC ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Thanks. We should remove the redundant selects from APL/SKL, see CB:31113.
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG@9 PS1, Line 9: Intel RTC common code driver need to turn on RTC itself. Maybe mention that this adds RTC for CNL/ICL.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31112 )
Change subject: soc/intel/common/rtc: Enable RTC if common code RTC ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG@7 PS1, Line 7: if in, maybe?
Hello Patrick Rudolph, Angel Pons, Subrata Banik, Duncan Laurie, build bot (Jenkins), Nico Huber, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31112
to look at the new patch set (#2).
Change subject: soc/intel/common/rtc: Enable RTC in common code RTC ......................................................................
soc/intel/common/rtc: Enable RTC in common code RTC
Intel RTC common code driver need to turn on RTC itself.After the change, cannonlake and icelake platform will have RTC enabled.
BUG=b:123372643 TEST=build and boot up on sarien platform, check .config to see CONFIG_RTC is set.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I0c8c5cf9e6f7f338b1f2f784c04254649d257536 --- M src/soc/intel/common/block/rtc/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/31112/2
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31112 )
Change subject: soc/intel/common/rtc: Enable RTC in common code RTC ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG@7 PS1, Line 7: if
in, maybe?
Done
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG@9 PS1, Line 9: Intel RTC common code driver need to turn on RTC itself.
Maybe mention that this adds RTC for CNL/ICL.
Done
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31112 )
Change subject: soc/intel/common/rtc: Enable RTC in common code RTC ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31112 )
Change subject: soc/intel/common/rtc: Enable RTC in common code RTC ......................................................................
soc/intel/common/rtc: Enable RTC in common code RTC
Intel RTC common code driver need to turn on RTC itself.After the change, cannonlake and icelake platform will have RTC enabled.
BUG=b:123372643 TEST=build and boot up on sarien platform, check .config to see CONFIG_RTC is set.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I0c8c5cf9e6f7f338b1f2f784c04254649d257536 Reviewed-on: https://review.coreboot.org/c/31112 Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/rtc/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Subrata Banik: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/block/rtc/Kconfig b/src/soc/intel/common/block/rtc/Kconfig index d194f15..eda2063 100644 --- a/src/soc/intel/common/block/rtc/Kconfig +++ b/src/soc/intel/common/block/rtc/Kconfig @@ -1,4 +1,5 @@ config SOC_INTEL_COMMON_BLOCK_RTC bool + select RTC help Intel Processor common RTC support
-
Angel Pons (Code Review) -
Lijian Zhao (Code Review)
-
Nico Huber (Code Review)
-
Subrata Banik (Code Review)