Ravishankar Sarawadi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43666 )
Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE ......................................................................
soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE
This patch increases PRERAM_CBMEM_CONSOLE_SIZE to fix *** Pre-CBMEM romstage console overflowed, log truncated! *** issue.
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: Id2ea64feb92ec29df5402b2fb1bac3ff73cc5bb3 --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/43666/1
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 091abb9..16f302b 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -210,5 +210,5 @@
config PRERAM_CBMEM_CONSOLE_SIZE hex - default 0xe00 + default 0x1400 endif
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43666 )
Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/43666/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43666/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE
… to X MB
Done
https://review.coreboot.org/c/coreboot/+/43666/1//COMMIT_MSG@9 PS1, Line 9: This patch increases PRERAM_CBMEM_CONSOLE_SIZE
from … KB to … KB to fix
Done
Hello Shaunak Saha, build bot (Jenkins), Jamie Ryu, Furquan Shaikh, Shreesh Chhabbi, Srinidhi N Kaushik, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43666
to look at the new patch set (#4).
Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB
This patch increases PRERAM_CBMEM_CONSOLE_SIZE from 3KB to 5KB to fix *** Pre-CBMEM romstage console overflowed, log truncated! *** issue.
Bug=None Branch=None Test=Boot Delbin and check 'cbmem -c | more' for full log message.
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: Id2ea64feb92ec29df5402b2fb1bac3ff73cc5bb3 --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/43666/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43666 )
Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
Patch Set 4: Code-Review+2
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43666 )
Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
Patch Set 4:
if no more review, could we merge this patch please?
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43666 )
Change subject: soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB ......................................................................
soc/intel/tigerlake: Increase PRERAM_CBMEM_CONSOLE_SIZE to 5KB
This patch increases PRERAM_CBMEM_CONSOLE_SIZE from 3KB to 5KB to fix *** Pre-CBMEM romstage console overflowed, log truncated! *** issue.
Bug=None Branch=None Test=Boot Delbin and check 'cbmem -c | more' for full log message.
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: Id2ea64feb92ec29df5402b2fb1bac3ff73cc5bb3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43666 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 2659357..63998d4 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -209,5 +209,5 @@
config PRERAM_CBMEM_CONSOLE_SIZE hex - default 0xe00 + default 0x1400 endif
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Ravishankar Sarawadi (Code Review)