Change in coreboot[master]: soc/intel/xeon_sp/cpx: add chip operation and PCIe enumeration
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40110 )
Change subject: soc/intel/xeon_sp/cpx: add chip operation and PCIe enumeration ......................................................................
Patch Set 15:
(4 comments)
Patch Set 15:
(4 comments)
Patch Set 15:
Discussion is in progress with coreboot community with related to the design of coreboot change needed in PCIe resource allocator. It will take some time to materialize However. In the mean time, we need this localized change to move forward with our work to add server features.
Understood. We should get rid of this code, eventually, as it's a parallel implementation to work around existing issues.
Totally on the same page. Work is being planned. On the other hand, we are awaiting for design feedbacks from you/Furquan.
https://review.coreboot.org/c/coreboot/+/40110/15/src/soc/intel/xeon_sp/cpx/... File src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h:
https://review.coreboot.org/c/coreboot/+/40110/15/src/soc/intel/xeon_sp/cpx/... PS15, Line 10: printk
#include <console/console. […]
Done
https://review.coreboot.org/c/coreboot/+/40110/15/src/soc/intel/xeon_sp/cpx/... PS15, Line 19: MAX_SOCKET * MAX_LOGIC_IIO_STAC
Where are these defines provided?
They are provided at src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_iiouds.h
https://review.coreboot.org/c/coreboot/+/40110/15/src/soc/intel/xeon_sp/cpx/... PS15, Line 22: uint8_t
Is stdint.h indirectly #included from hob_iiouds. […]
yes, this is the same case for console.h as well.
https://review.coreboot.org/c/coreboot/+/40110/15/src/soc/intel/xeon_sp/cpx/... File src/soc/intel/xeon_sp/cpx/soc_util.c:
https://review.coreboot.org/c/coreboot/+/40110/15/src/soc/intel/xeon_sp/cpx/... PS15, Line 34: MAX_IIO_STACK
If this is number of resources we should name this better.
MAX_IIO_STACK is the maximum number of IIO stacks per socket. On the other hand, MAX_SOCKET is the maximum number of sockets.
-
Jonathan Zhang (Code Review)