Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )
Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices ......................................................................
Patch Set 8:
(6 comments)
File src/soc/amd/cezanne/fch.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139825): https://review.coreboot.org/c/coreboot/+/61259/comment/e16a0505_8855a755 PS8, Line 189: dxio_desc->device_number, dxio_desc->function_number, i, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139825): https://review.coreboot.org/c/coreboot/+/61259/comment/a6e1f3cd_32a51e1a PS8, Line 194: /* Check for mismatches between disabled devices and SoC gpp_clk_config. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139825): https://review.coreboot.org/c/coreboot/+/61259/comment/32e497e4_8dae9327 PS8, Line 194: /* Check for mismatches between disabled devices and SoC gpp_clk_config. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139825): https://review.coreboot.org/c/coreboot/+/61259/comment/81d2b386_068e57e2 PS8, Line 202: /* trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139825): https://review.coreboot.org/c/coreboot/+/61259/comment/76505d3d_e4966660 PS8, Line 210: dxio_desc->function_number, gpp_req_index, i); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139825): https://review.coreboot.org/c/coreboot/+/61259/comment/973b8d28_36f8ebca PS8, Line 215: dxio_desc->function_number, gpp_req_index, i); line over 96 characters