Change in coreboot[master]: assert.h: add assertions with descriptive failuresx

[Felix Held (Code Review)]

Hello Eric Peers,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/39620

to review the following change.

Change subject: assert.h: add assertions with descriptive failuresx
......................................................................

assert.h: add assertions with descriptive failuresx

BUG=None
TEST=tested in following patches on Trembyle board

Change-Id: Ib30ccd41759e5a2a61d3182cc08ed5eb762eca98
Signed-off-by: Eric Peers 
Reviewed-on: https://chromium-review.googlesource.com/1971443
Tested-by: Martin Roth 
Reviewed-by: Martin Roth 
---
M src/include/assert.h
1 file changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/39620/1

diff --git a/src/include/assert.h b/src/include/assert.h
index 8f5af1f..990cee1 100644
--- a/src/include/assert.h
+++ b/src/include/assert.h
@@ -33,6 +33,17 @@
    		hlt();					\
    }							\
 }
+
+#define ASSERT_MSG(x, msg) {					\
+	if (!(x)) {						\
+		printk(BIOS_EMERG, "ASSERTION ERROR: file '%s'"	\
+			", line %d\n", __FILE__, __LINE__);	\
+		printk(BIOS_EMERG, "%s", msg);                  \
+		if (CONFIG(FATAL_ASSERTS))			\
+			hlt();					\
+	}							\
+}
+
 #define BUG() {							\
    printk(BIOS_EMERG, "ERROR: BUG ENCOUNTERED at file '%s'"\
    	", line %d\n", __FILE__, __LINE__);		\

Change in coreboot[master]: assert.h: add assertions with descriptive failures

[Felix Held (Code Review)]

Hello Eric Peers,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39620

to look at the new patch set (#2).

Change subject: assert.h: add assertions with descriptive failures
......................................................................

assert.h: add assertions with descriptive failures

BUG=None
TEST=tested in following patches on Trembyle board

Change-Id: Ib30ccd41759e5a2a61d3182cc08ed5eb762eca98
Signed-off-by: Eric Peers 
Reviewed-on: https://chromium-review.googlesource.com/1971443
Tested-by: Martin Roth 
Reviewed-by: Martin Roth 
---
M src/include/assert.h
1 file changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/39620/2

Change in coreboot[master]: assert.h: add assertions with descriptive failures

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39620 )

Change subject: assert.h: add assertions with descriptive failures
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: assert.h: add assertions with descriptive failures

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39620 )

Change subject: assert.h: add assertions with descriptive failures
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: assert.h: add assertions with descriptive failures

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39620 )

Change subject: assert.h: add assertions with descriptive failures
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: assert.h: add assertions with descriptive failures

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39620 )

Change subject: assert.h: add assertions with descriptive failures
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: assert.h: add assertions with descriptive failures

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39620 )

Change subject: assert.h: add assertions with descriptive failures
......................................................................

assert.h: add assertions with descriptive failures

BUG=None
TEST=tested in following patches on Trembyle board

Change-Id: Ib30ccd41759e5a2a61d3182cc08ed5eb762eca98
Signed-off-by: Eric Peers 
Reviewed-on: https://chromium-review.googlesource.com/1971443
Tested-by: Martin Roth 
Reviewed-by: Martin Roth 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39620
Tested-by: build bot (Jenkins) 
Reviewed-by: Martin Roth 
Reviewed-by: Angel Pons 
Reviewed-by: Raul Rangel 
Reviewed-by: Paul Menzel 
---
M src/include/assert.h
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Raul Rangel: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/include/assert.h b/src/include/assert.h
index 8f5af1f..990cee1 100644
--- a/src/include/assert.h
+++ b/src/include/assert.h
@@ -33,6 +33,17 @@
    		hlt();					\
    }							\
 }
+
+#define ASSERT_MSG(x, msg) {					\
+	if (!(x)) {						\
+		printk(BIOS_EMERG, "ASSERTION ERROR: file '%s'"	\
+			", line %d\n", __FILE__, __LINE__);	\
+		printk(BIOS_EMERG, "%s", msg);                  \
+		if (CONFIG(FATAL_ASSERTS))			\
+			hlt();					\
+	}							\
+}
+
 #define BUG() {							\
    printk(BIOS_EMERG, "ERROR: BUG ENCOUNTERED at file '%s'"\
    	", line %d\n", __FILE__, __LINE__);		\

Change in coreboot[master]: assert.h: add assertions with descriptive failures

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39620 )

Change subject: assert.h: add assertions with descriptive failures
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1431
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1430
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1429

Please note: This test is under development and might not be accurate at all!