Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27276 )
Change subject: soc/amd/common: Remove redundant ACPI S3 test ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/27276/4/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/27276/4/src/soc/amd/common/block/pi/agesawra... PS4, Line 425: : :
Essentially the return parameter is only used for debug message, it does not block continuation of c […]
You do not even reach do_agesawrapper() lines calling these functions, with HAVE_ACPI_RESUME=n. As the commit message says, redundant tests.
Furthermore, sleepstates.asl also does not advertise ACPI S3 support when HAVE_ACPI_RESUME=n. Whether OS acpid and GUIs honour that is another question and not within our reach to fix.
Let me know how this commit fails on hardware testing.
-
Kyösti Mälkki (Code Review)