[L] Change in coreboot[main]: soc/amd/genoa: Add GPIO definitions - coreboot-gerrit

10 Oct 2023


      Attention is currently required from: Felix Held, Martin Roth.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78220?usp=email )
Change subject: soc/amd/genoa: Add GPIO definitions
......................................................................
Patch Set 8:
(2 comments)
File src/soc/amd/genoa/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/78220/comment/e2043113_c40de797 :
PS7, Line 41: #define GPIO_28				28
...
i'd drop this one, since it doesn't seem to exist on the package
Done
https://review.coreboot.org/c/coreboot/+/78220/comment/ae7731c8_a5f766f5 :
PS7, Line 148: #define GPIO_28_IOMUX_GPIOxx 1
...
i don't see this pin on the package, so we should probably not include it here
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78220?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0c4e425699c9a158ca95a1baf94f7756f0b12b44
Gerrit-Change-Number: 78220
Gerrit-PatchSet: 8
Gerrit-Owner: Varshit Pandya pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 10 Oct 2023 16:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment