EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33299
Change subject: mb/google/poppy/variants/nami: remove redundant break ......................................................................
mb/google/poppy/variants/nami: remove redundant break
Break never comes after return, remove it.
BUG=N/A BRANCH=firmware-nami-10775.108.B TEST=N/A
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I005918d6a04cd21df496dea0f2cb1ed6108675af --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/33299/1
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 2387017..adb8c00 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -215,7 +215,6 @@ return "vbt-bard.bin"; default: return "vbt.bin"; - break; } }
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33299 )
Change subject: mb/google/poppy/variants/nami: remove redundant break ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33299 )
Change subject: mb/google/poppy/variants/nami: remove redundant break ......................................................................
Patch Set 1: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33299 )
Change subject: mb/google/poppy/variants/nami: remove redundant break ......................................................................
mb/google/poppy/variants/nami: remove redundant break
Break never comes after return, remove it.
BUG=N/A BRANCH=firmware-nami-10775.108.B TEST=N/A
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I005918d6a04cd21df496dea0f2cb1ed6108675af Reviewed-on: https://review.coreboot.org/c/coreboot/+/33299 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 2387017..adb8c00 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -215,7 +215,6 @@ return "vbt-bard.bin"; default: return "vbt.bin"; - break; } }