Change in coreboot[master]: amdfwtool: Check the length of matching string before accessing - coreboot-gerrit

1 Mar 2022


      Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Paul Menzel, Zheng Bao, Nikolai Vyssotski, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62483 )
Change subject: amdfwtool: Check the length of matching string before accessing
......................................................................
Patch Set 4:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/62483/comment/aaafb804_6ea7384d 
PS4, Line 535: 						if ((match[3].rm_eo - match[3].rm_so) >= 3)
...
Too many leading tabs - consider code refactoring
Please fix.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62483
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd8ffe34fd44d860ec2115cd36117da7b02169cd
Gerrit-Change-Number: 62483
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 01 Mar 2022 15:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment