Change in coreboot[master]: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Xi Chen (Code Review)

23 Dec 2020 23 Dec '20

4:58 p.m.

Xi Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48869 )

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

TEST-ONLY: src/mediatek/mt8192: force full calibration for blob

Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 --- M src/soc/mediatek/mt8192/memory.c 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/48869/1

diff --git a/src/soc/mediatek/mt8192/memory.c b/src/soc/mediatek/mt8192/memory.c index 07c4b9f..ad84ad7 100644 --- a/src/soc/mediatek/mt8192/memory.c +++ b/src/soc/mediatek/mt8192/memory.c @@ -10,6 +10,8 @@ #include <symbols.h> #include <timer.h>

+#define FORCE_FULL_K + static int mt_mem_test(const struct dramc_data *dparam) { if (CONFIG(MEMORY_TEST)) { @@ -148,7 +150,11 @@

/* Load calibration params from flash and run fast calibration */ mem_init_set_default_config(dparam, dram_info); +#ifdef FORCE_FULL_K + if (0) { +#else if (dparam_ops->read_from_flash(dparam)) { +#endif printk(BIOS_INFO, "DRAM-K: Running fast calibration\n"); stopwatch_init(&sw);

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Xi Chen (Code Review)

3 Mar 3 Mar

5:13 p.m.

Hello Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48869

to look at the new patch set (#2).

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

TEST-ONLY: src/mediatek/mt8192: force full calibration for blob

Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 --- M src/soc/mediatek/common/memory.c 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/48869/2

Yu-Ping Wu (Code Review)

15 Apr 15 Apr

12:20 p.m.

Attention is currently required from: Xi Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48869 )

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: Please abandon this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 Gerrit-Change-Number: 48869 Gerrit-PatchSet: 2 Gerrit-Owner: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Xi Chen xixi.chen@mediatek.com Gerrit-Comment-Date: Thu, 15 Apr 2021 02:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Xi Chen (Code Review)

1:56 p.m.

Attention is currently required from: Yu-Ping Wu. Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48869 )

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:

...

Please abandon this.

It's for test, and need abandon?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 Gerrit-Change-Number: 48869 Gerrit-PatchSet: 2 Gerrit-Owner: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Thu, 15 Apr 2021 03:56:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

3:55 p.m.

Attention is currently required from: Xi Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48869 )

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:

...

It's for test, and need abandon?

Even if it's abandoned, you can still cherry-pick it locally. Is that enough for testing?

If you still need an open CL for testing, I'd suggest moving it to chromium.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 Gerrit-Change-Number: 48869 Gerrit-PatchSet: 2 Gerrit-Owner: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Xi Chen xixi.chen@mediatek.com Gerrit-Comment-Date: Thu, 15 Apr 2021 05:55:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Xi Chen xixi.chen@mediatek.com Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Xi Chen (Code Review)

5:49 p.m.

Attention is currently required from: Yu-Ping Wu. Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48869 )

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2:

...

Even if it's abandoned, you can still cherry-pick it locally. Is that enough for testing? […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 Gerrit-Change-Number: 48869 Gerrit-PatchSet: 2 Gerrit-Owner: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Thu, 15 Apr 2021 07:49:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Xi Chen xixi.chen@mediatek.com Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Xi Chen (Code Review)

5:49 p.m.

Xi Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48869 )

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

Abandoned

Xi Chen (Code Review)

30 Apr 30 Apr

5:25 p.m.

Xi Chen has restored this change. ( https://review.coreboot.org/c/coreboot/+/48869 )

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/48869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 Gerrit-Change-Number: 48869 Gerrit-PatchSet: 2 Gerrit-Owner: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: restore

Xi Chen (Code Review)

5:26 p.m.

Attention is currently required from: Xixi Chen. Hello Hung-Te Lin, build bot (Jenkins), Xixi Chen, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48869

to look at the new patch set (#3).

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

TEST-ONLY: src/mediatek/mt8192: force full calibration for blob

Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 Signed-off-by: Xi Chen xixi.chen@mediatek.corp-partner.google.com --- M src/soc/mediatek/common/memory.c 1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/48869/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/48869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 Gerrit-Change-Number: 48869 Gerrit-PatchSet: 3 Gerrit-Owner: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Xixi Chen xixi.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Xixi Chen xixi.chen@mediatek.corp-partner.google.com Gerrit-MessageType: newpatchset

Xi Chen (Code Review)

5:27 p.m.

Xi Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48869 )

Change subject: TEST-ONLY: src/mediatek/mt8192: force full calibration for blob ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/48869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8cab81af29aaa9b2b56ff9f655bb9580f2abee19 Gerrit-Change-Number: 48869 Gerrit-PatchSet: 3 Gerrit-Owner: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Xixi Chen xixi.chen@mediatek.corp-partner.google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

1256

days inactive

1384

days old

coreboot-gerrit@coreboot.org

9 comments

2 participants

tags (0)

participants (2)

Xi Chen (Code Review)
Yu-Ping Wu (Code Review)