Attention is currently required from: Jason Glenesk, Raul Rangel, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50270 )
Change subject: soc/amd/cezanne/fch: add ACPI I/O port setup
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/soc/amd/cezanne/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/50270/comment/31854bf9_d85658b8
PS1, Line 19: 0x0400
Curious why not use CONFIG_CEZANNE_ACPI_IO_BASE. 0x400 should be fine though.
https://review.coreboot.org/c/coreboot/+/50270/comment/664ef160_31ed8c83
PS1, Line 25: 0x10
This differs from Picasso. Was changed in CB:44135 however I believe we stripped it from AGESA so it shouldn't be an issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If80b841df12d351d5a0c1e0d2e7bf1e31b03447f
Gerrit-Change-Number: 50270
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 04 Feb 2021 18:58:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment