Attention is currently required from: Hung-Te Lin, Paul Menzel, Angel Pons.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62471 )
Change subject: soc/mediatek/mt8186: Add GPIO driving functions
......................................................................
Patch Set 9:
(2 comments)
File src/soc/mediatek/common/include/soc/gpio_common.h:
https://review.coreboot.org/c/coreboot/+/62471/comment/93e1cb3e_1796517d
PS4, Line 31: };
This enum provides no benefit. I'd rather define the specific enum values in soc/gpio. […]
Done
File src/soc/mediatek/mt8186/gpio.c:
https://review.coreboot.org/c/coreboot/+/62471/comment/d396e0b4_88070045
PS8, Line 203: { -1, -1, -1, }
I imagine this indicates the bitfield isn't implemented for this GPIO. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d987f28be98b515fa5c542222bda08bea1d5118
Gerrit-Change-Number: 62471
Gerrit-PatchSet: 9
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 04 Mar 2022 11:37:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment