Attention is currently required from: Martin L. Roth, Stefan Reinauer, Nicholas Chin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57222 )
Change subject: payloads/external: Add support for coreDOOM payload
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57222/comment/3c94916a_40dab4a8
PS4, Line 9: coreDOOM is a port of the doomgeneric source port of DOOM to libpayload, drawing
Please wrap lines after 72 characters.
Patchset:
PS3:
Hmm, I've only tested it with "CONFIG_GENERIC_LINEAR_FRAMEBUFFER", so I'm not sure what Kconfig sett […]
I got it to work with QEMU now. Thank you.
File payloads/Kconfig:
https://review.coreboot.org/c/coreboot/+/57222/comment/93b1d5d9_0c446e61
PS4, Line 154: or any other payload that can load additional payloads.
… It needs the generic linear framebuffer.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice0403b003a4b2717afee585f28303c2f5abea5d
Gerrit-Change-Number: 57222
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin L. Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L. Roth
martinroth@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nicholas Chin
Gerrit-Comment-Date: Sun, 23 Jan 2022 21:57:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Nicholas Chin
Gerrit-MessageType: comment