Attention is currently required from: Jamie Ryu, Ravishankar Sarawadi, Tim Wawrzynczak, Julius Werner, Subrata Banik, Nick Vaccaro, Srinidhi N Kaushik, Raj Astekar.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58839 )
Change subject: src/lib: Add FW_CONIFG_SOURCE_VPD
......................................................................
Patch Set 9:
(3 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/58839/comment/dffa8158_8924a902
PS4, Line 421: depends on FW_CONFIG
`depends on FW_CONFIG && VPD`
Ack
File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/58839/comment/cc6e909e_dbca2a66
PS4, Line 51: int32_t
nit: `int`, then no casting is needed below?
It looks compiler is allow without cast.
https://review.coreboot.org/c/coreboot/+/58839/comment/7a1e8b9d_43ae23f6
PS4, Line 59: fw_config_value = UNDEFINED_FW_CONFIG;
this line is redundant
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4df7d5612e18957416a40ab854fa63c8b11b4216
Gerrit-Change-Number: 58839
Gerrit-PatchSet: 9
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Wed, 03 Nov 2021 21:49:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment