Attention is currently required from: Jamie Ryu, Ravishankar Sarawadi, Tim Wawrzynczak, Julius Werner, Subrata Banik, Nick Vaccaro, Srinidhi N Kaushik, Raj Astekar.

View Change

3 comments:

• File src/Kconfig:

  • Patch Set #4, Line 421: depends on FW_CONFIG

    `depends on FW_CONFIG && VPD`

    Ack

• File src/lib/fw_config.c:

  • Patch Set #4, Line 51: int32_t

    nit: `int`, then no casting is needed below?

    It looks compiler is allow without cast.

  • Patch Set #4, Line 59: fw_config_value = UNDEFINED_FW_CONFIG;

    this line is redundant

    Ack

To view, visit change 58839. To unsubscribe, or for help writing mail filters, visit settings.