Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35896 )
Change subject: HACK sc7180: bootblock/verstage/romstage need to zero bss HACK ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35896/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35896/1//COMMIT_MSG@8 PS1, Line 8: Could you please provide the reasoning here as to why this is needed?
https://review.coreboot.org/c/coreboot/+/35896/1/src/security/vboot/verstage... File src/security/vboot/verstage.c:
https://review.coreboot.org/c/coreboot/+/35896/1/src/security/vboot/verstage... PS1, Line 28: memset(_bss, 0, (_ebss-_bss)); This is the wrong place for this hack.