Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29371 )
Change subject: drivers/intel/fsp1_1/raminit.c: Make check FSP HOBs independent of CONFIG_DISPLAY_HOBS
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/29371/4/src/drivers/intel/fsp1_1/raminit.c
File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/#/c/29371/4/src/drivers/intel/fsp1_1/raminit.c@1...
PS4, Line 190: } else if (IS_ENABLED(CONFIG_DISPLAY_HOBS)) {
IS_ENABLED is deprecated, use CONFIG() macro in the file
https://review.coreboot.org/#/c/29371/4/src/drivers/intel/fsp1_1/ramstage.c
File src/drivers/intel/fsp1_1/ramstage.c:
https://review.coreboot.org/#/c/29371/4/src/drivers/intel/fsp1_1/ramstage.c@...
PS4, Line 64: if (IS_ENABLED(CONFIG_DISPLAY_HOBS))
IS_ENABLED is deprecated, please use CONFIG() macro
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29371
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3776fa37866c7ef3aea090842387660c22bbdd4d
Gerrit-Change-Number: 29371
Gerrit-PatchSet: 4
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: York Yang
yyang024@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Apr 2019 11:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment