Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33418 )
Change subject: soc/intel/fsp_broadwell_de: Implement sa_get_tseg_base()
......................................................................
Patch Set 4:
Patch Set 4: Code-Review-1
CB:34745
I have request to always define this in memmap.c to make it available in all stages.
Denied. There's no point in having this in all stages.
There's no postcar stage and the function isn't usable before RAM as FSP1.0 haven't been run yet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33418
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22123cbf8d65b25a77fbf72ae8411b23b10c13b4
Gerrit-Change-Number: 33418
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen
rgzwen@arista.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 22 Aug 2019 07:23:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment