Attention is currently required from: Derek Huang, Joey Peng, Paul Menzel, Reka Norman.
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78146?usp=email )
Change subject: mb/google/dedede/var/boxy: Wait up for 3s for HPD ready signal ......................................................................
Patch Set 8:
(4 comments)
File src/mainboard/google/dedede/variants/boxy/ramstage.c:
https://review.coreboot.org/c/coreboot/+/78146/comment/3fbb0e16_4e4498b8 : PS8, Line 68:
Are you sure we can get the correct gpio state by get_gpio() without configuring the gpio to input?
new patch 9 for configuring GPIO_HDMI_HPD to input and get correct state.
https://review.coreboot.org/c/coreboot/+/78146/comment/a23b7dcb_df3d0eec : PS8, Line 70: && !gpio_get(GPIO_USB_C0_HPD)
this is redundant.
Done
https://review.coreboot.org/c/coreboot/+/78146/comment/1a3b1d97_e45939d9 : PS8, Line 74: && !gpio_get(GPIO_USB_C1_HPD
this is redundant
Done
https://review.coreboot.org/c/coreboot/+/78146/comment/b324350c_e033ed5a : PS8, Line 69: if (display_init_required() : && !gpio_get(GPIO_USB_C0_HPD)) { : /* This has to be done before FSP-S runs. */ : wait_for_hpd(GPIO_USB_C0_HPD, display_timeout_ms); : } else if (display_init_required() : && !gpio_get(GPIO_USB_C1_HPD)) { : /* This has to be done before FSP-S runs. */ : wait_for_hpd(GPIO_USB_C1_HPD, display_timeout_ms); : }
If only HDMI is connected, these will always timeout and add 6s delay. […]
Upload patch 9 to remove wait_for_hpd() and add 3s delay directly with non-HDMI display case due to Boxy display output only have HDMI or typC port C1/C2 case, and C1/C2 case should waiting 3s for USBC dongle