Change in coreboot[master]: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51551 )

Change subject: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS3:
> Jenkins' comments are automatically tagged resolved and I treat them like that. It's just a comment that something _might_ be better written another way. Maybe we should adapt the comment texts to reflect that?

I don't think there's anything wrong or in need of change with how the comments are presented right now, I just think that one way or the other there will always be people interpreting them differently. I have also seen cases where Jenkins spammed line-length or MS-DOS line ending warnings on every line and the patch author remained completely oblivious that there was any action required from them until I had to manually point it out. So I wouldn't necessarily want to make the language these comments are presented in even weaker either.

Anyway, I never meant to discuss this option to death... I just never noticed it being helpful and frequently noticed it being annoying in the years since it was added so I thought it would be nice to get rid of. Sounds like your experience has been different. If you feel strongly about it feel free to submit a patch to enable it again, I never expected this to be very controversial. Sorry this went through before you had a chance to respond again.