Change in ...coreboot[master]: mb/emulation/qemu-i449fx: prepare fw_cfg for romstage usage

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Thomas Heijligen (Code Review)

11 Jan 2019 11 Jan '19

7:29 a.m.

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30846

Change subject: mb/emulation/qemu-i449fx: prepare fw_cfg for romstage usage ......................................................................

mb/emulation/qemu-i449fx: prepare fw_cfg for romstage usage

Add separate functions for selecting the port and reading the port. Romstage can now read incremental from the data port.

Change-Id: I0ffde3bc2a4415a8af99af2275d16f6609099e37 Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com --- M src/mainboard/emulation/qemu-i440fx/fw_cfg.c 1 file changed, 11 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/30846/1

diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index 9b394f2..957e9d2 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -42,12 +42,22 @@ return fw_cfg_detected; }

-void fw_cfg_get(int entry, void *dst, int dstlen) +static void fw_cfg_select(int entry) { outw(entry, FW_CFG_PORT_CTL); +} + +static void fw_cfg_read(void *dst, int dstlen) +{ insb(FW_CFG_PORT_DATA, dst, dstlen); }

+void fw_cfg_get(int entry, void *dst, int dstlen) +{ + fw_cfg_select(entry); + fw_cfg_read(dst, dstlen); +} + static void fw_cfg_init_file(void) { u32 i, size, count = 0;

Attachments:

attachment.htm (text/html — 3.4 KB)

Show replies by date

Angel Pons (Code Review)

11 Jan 11 Jan

11:08 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30846 )

Change subject: mb/emulation/qemu-i449fx: prepare fw_cfg for romstage usage ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30846/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30846/1//COMMIT_MSG@7 PS1, Line 7: i449fx i440fx

-- To view, visit https://review.coreboot.org/c/coreboot/+/30846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ffde3bc2a4415a8af99af2275d16f6609099e37 Gerrit-Change-Number: 30846 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 11 Jan 2019 19:08:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

14 Jan 14 Jan

1:52 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30846 )

Change subject: mb/emulation/qemu-i449fx: prepare fw_cfg for romstage usage ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/30846/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:

https://review.coreboot.org/#/c/30846/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 45: static void fw_cfg_select(int entry) uint16_t

https://review.coreboot.org/#/c/30846/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 55: void fw_cfg_get(int entry, void *dst, int dstlen) uint16_t

-- To view, visit https://review.coreboot.org/c/coreboot/+/30846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ffde3bc2a4415a8af99af2275d16f6609099e37 Gerrit-Change-Number: 30846 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen src@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 14 Jan 2019 09:52:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Thomas Heijligen (Code Review)

2:39 a.m.

New subject: Change in ...coreboot[master]: mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30846

to look at the new patch set (#2).

Change subject: mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage ......................................................................

mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage

Add separate functions for selecting the port and reading the port. Romstage can now read incremental from the data port.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/30846/2

Thomas Heijligen (Code Review)

15 Jan 15 Jan

6:02 a.m.

New subject: Change in ...coreboot[master]: mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30846 )

Change subject: mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage ......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/30846/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/30846/1//COMMIT_MSG@7 PS1, Line 7: i449fx

...

i440fx

Done

https://review.coreboot.org/#/c/30846/1/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:

https://review.coreboot.org/#/c/30846/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 45: static void fw_cfg_select(int entry)

...

uint16_t

Done

https://review.coreboot.org/#/c/30846/1/src/mainboard/emulation/qemu-i440fx/... PS1, Line 55: void fw_cfg_get(int entry, void *dst, int dstlen)

...

uint16_t

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/30846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ffde3bc2a4415a8af99af2275d16f6609099e37 Gerrit-Change-Number: 30846 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen src@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Tue, 15 Jan 2019 14:02:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

11:29 p.m.

New subject: Change in ...coreboot[master]: mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30846 )

Change subject: mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/30846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ffde3bc2a4415a8af99af2275d16f6609099e37 Gerrit-Change-Number: 30846 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen src@posteo.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Wed, 16 Jan 2019 07:29:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

31 Jan 31 Jan

12:39 a.m.

New subject: Change in ...coreboot[master]: mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30846 )

Change subject: mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage ......................................................................

mb/emulation/qemu-i440fx: prepare fw_cfg for romstage usage

Add separate functions for selecting the port and reading the port. Romstage can now read incremental from the data port.

Change-Id: I0ffde3bc2a4415a8af99af2275d16f6609099e37 Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com Reviewed-on: https://review.coreboot.org/c/30846 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.h 2 files changed, 12 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved

diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index 9b394f2..364221e 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -42,12 +42,22 @@ return fw_cfg_detected; }

-void fw_cfg_get(int entry, void *dst, int dstlen) +static void fw_cfg_select(uint16_t entry) { outw(entry, FW_CFG_PORT_CTL); +} + +static void fw_cfg_read(void *dst, int dstlen) +{ insb(FW_CFG_PORT_DATA, dst, dstlen); }

+void fw_cfg_get(uint16_t entry, void *dst, int dstlen) +{ + fw_cfg_select(entry); + fw_cfg_read(dst, dstlen); +} + static void fw_cfg_init_file(void) { u32 i, size, count = 0; diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.h b/src/mainboard/emulation/qemu-i440fx/fw_cfg.h index b5cdb92..91b758c 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.h +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.h @@ -14,7 +14,7 @@ #define FW_CFG_H #include "fw_cfg_if.h"

-void fw_cfg_get(int entry, void *dst, int dstlen); +void fw_cfg_get(uint16_t entry, void *dst, int dstlen); int fw_cfg_check_file(FWCfgFile *file, const char *name); int fw_cfg_max_cpus(void); unsigned long fw_cfg_smbios_tables(int *handle, unsigned long *current);

-- To view, visit https://review.coreboot.org/c/coreboot/+/30846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ffde3bc2a4415a8af99af2275d16f6609099e37 Gerrit-Change-Number: 30846 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen src@posteo.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: merged

2117

days inactive

2137

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Thomas Heijligen (Code Review)