Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50380 )
Change subject: mb/prodrive/hermes: Drop reset functions ......................................................................
mb/prodrive/hermes: Drop reset functions
The reset GPIOs are already configured in bootblock. Drop the unused ramstage code.
Change-Id: Ic99fcae2a3f00be7eebd7be618df838522dac69f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/50380 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/prodrive/hermes/mainboard.c 1 file changed, 1 insertion(+), 20 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index f2bbbba..822ed58 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -25,21 +25,6 @@ gpio_output(GPP_K5, enable); }
-static void mb_pcie_reset_pch_slots(bool enable) -{ - gpio_output(GPP_K0, enable); -} - -static void mb_pcie_reset_cpu_slots(bool enable) -{ - gpio_output(GPP_K1, enable); -} - -static void mb_pcie_reset_cnvi_slot(bool enable) -{ - gpio_output(GPP_K2, enable); -} - static void mb_hda_amp_enable(bool enable) { gpio_output(GPP_C19, enable); @@ -136,11 +121,7 @@ mb_configure_dp1_pwr(1); mb_configure_dp2_pwr(1); mb_configure_dp3_pwr(1); - if (0) { - mb_pcie_reset_pch_slots(1); - mb_pcie_reset_cpu_slots(0); - mb_pcie_reset_cnvi_slot(0); - } + mb_hda_amp_enable(1); mb_usb31_rp1_pwr_enable(1); mb_usb31_rp2_pwr_enable(1);