Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34592 )
Change subject: vc/cavium/bdk/libdram: Remove unused assignment ......................................................................
vc/cavium/bdk/libdram: Remove unused assignment
The total number of errors is only needed after a final tuning run at the end of this function, so we can remove this unneeded store for earlier runs.
Change-Id: I62adb38ccba98d90bcf8ccd13998762b9b694111 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1393967 --- M src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/34592/1
diff --git a/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c b/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c index 385acee..291fe85 100644 --- a/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c +++ b/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c @@ -655,7 +655,7 @@
// run the test(s) // only 1 call should be enough, let the bursts, etc, control the load... - tot_errors = run_dram_tuning_threads(node, num_lmcs, bytemask); + run_dram_tuning_threads(node, num_lmcs, bytemask);
for (lmc = 0; lmc < num_lmcs; lmc++) { // record stop cycle CSRs here for utilization measure
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34592 )
Change subject: vc/cavium/bdk/libdram: Remove unused assignment ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34592 )
Change subject: vc/cavium/bdk/libdram: Remove unused assignment ......................................................................
vc/cavium/bdk/libdram: Remove unused assignment
The total number of errors is only needed after a final tuning run at the end of this function, so we can remove this unneeded store for earlier runs.
Change-Id: I62adb38ccba98d90bcf8ccd13998762b9b694111 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1393967 Reviewed-on: https://review.coreboot.org/c/coreboot/+/34592 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c b/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c index 385acee..291fe85 100644 --- a/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c +++ b/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c @@ -655,7 +655,7 @@
// run the test(s) // only 1 call should be enough, let the bursts, etc, control the load... - tot_errors = run_dram_tuning_threads(node, num_lmcs, bytemask); + run_dram_tuning_threads(node, num_lmcs, bytemask);
for (lmc = 0; lmc < num_lmcs; lmc++) { // record stop cycle CSRs here for utilization measure