Selma Bensaid has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35347 )
Change subject: mb/google/drallion: Use arcada_ish.bin for arcada_cml ......................................................................
mb/google/drallion: Use arcada_ish.bin for arcada_cml
drallion_ish.bin is updated for drallion GPIO changes and not compatible with arcada_cml.
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: Idb35c33425bfd50533df74349dd645db18a65bc5 --- M src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35347/1
diff --git a/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb b/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb index 3628264..9e5be93 100644 --- a/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb +++ b/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb @@ -231,7 +231,7 @@ device pci 12.6 off end # GSPI #2 device pci 13.0 on # Integrated Sensor Hub chip drivers/intel/ish - register "firmware_name" = ""drallion_ish.bin"" + register "firmware_name" = ""arcada_ish.bin"" device generic 0 on end end end
Selma Bensaid has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35347 )
Change subject: mb/google/drallion: Use arcada_ish.bin for arcada_cml ......................................................................
mb/google/drallion: Use arcada_ish.bin for arcada_cml
drallion_ish.bin is updated for drallion GPIO changes and not compatible with arcada_cml.
TEST=Build and boot arcada_cml
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: Idb35c33425bfd50533df74349dd645db18a65bc5 --- M src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/35347/2
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35347 )
Change subject: mb/google/drallion: Use arcada_ish.bin for arcada_cml ......................................................................
Patch Set 2: Code-Review+2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35347 )
Change subject: mb/google/drallion: Use arcada_ish.bin for arcada_cml ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35347 )
Change subject: mb/google/drallion: Use arcada_ish.bin for arcada_cml ......................................................................
mb/google/drallion: Use arcada_ish.bin for arcada_cml
drallion_ish.bin is updated for drallion GPIO changes and not compatible with arcada_cml.
TEST=Build and boot arcada_cml
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: Idb35c33425bfd50533df74349dd645db18a65bc5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35347 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Bora Guvendik bora.guvendik@intel.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Bora Guvendik: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb b/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb index 7050b1e..5f396fe 100644 --- a/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb +++ b/src/mainboard/google/drallion/variants/arcada_cml/devicetree.cb @@ -230,7 +230,7 @@ device pci 12.6 off end # GSPI #2 device pci 13.0 on # Integrated Sensor Hub chip drivers/intel/ish - register "firmware_name" = ""drallion_ish.bin"" + register "firmware_name" = ""arcada_ish.bin"" device generic 0 on end end end
-
Bora Guvendik (Code Review) -
EricR Lai (Code Review)
-
Patrick Georgi (Code Review)
-
Selma Bensaid (Code Review)